User tests: Successful: Unsuccessful:
Pull Request for Issue #23845.
Use the getName function instead of getClientId function in the system/debug plugin.
Add the getName function in the ConsoleApplication class.
See the @SniperSister comment:
#23859 (comment)
Enable Debug System.
And try:
php cli/joomla.php list
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
Category | Libraries | ⇒ | Administration Libraries |
@twister65 When doing a php cli/joomla.php list
, I get a PHP fatal error in any case, with and without your PR applied, and with and without the debug system on:
PHP Fatal error: Declaration of Joomla\CMS\Application\ConsoleApplication::doExecute() must be compatible with Joomla\Console\Application::doExecute(): int in /home/richard/lamp/public_html/joomla-cms-4.0-dev/libraries/src/Application/ConsoleApplication.php on line 32
Am I making some mistake?
Thanks Michael.
@richard67 , to test you can replace this line:
https://github.com/twister65/joomla-cms/blob/bd271abc484a5ac25a5d1d365d20440d9dafc3e9/libraries/src/Application/ConsoleApplication.php#L126
by:
protected function doExecute(): int
waiting for a new PR...
@twister65 To fix that 1 line leads to the next error, so it needs to pull the latest changes from the framework for the console package. But a composer update
does not do anything, so I think there is something wrong, see my comments above. If that will be done, I am sure also #25374 will be fixed.
If a composer update
is not doing anything then that means the CMS already has the latest code. The problem is not needing another composer update
, the problem is the CMS subclass of Joomla\Console\Application
needs updates to match changes from the parent repo.
I see, thanks again Michael.
To all: Is there already anybody working on that?
PR for synching the function signatures in the subclass of the console application to the changes in the framework package as explained by Michael is PR #25391 . Thanks to @HLeithner for that.
@twister65 That PR is requirement for this PR here to be tested. Please test it.
@twister65 P.S.: When that other PR will be merged, you will have to rebase this here and solve merge conflicts.
Category | Libraries Administration | ⇒ | Administration Libraries Front End Plugins |
Title |
|
I have tested this item
I have tested this item
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-02 22:58:25 |
Closed_By | ⇒ | wilsonge |
Thanks!
IMO, would be better to use application name. ID is so meaningless.