? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Jun 2019

We have a large block of text on every permissions tab right at the bottom. Among the many problems with a large block of text like this is accessibility. Text like "see notes at the bottom" just doesn't work for assistive tech. Luckily there is a really easy solution. Using the html elements <summary> and <details>. The <details> element generates a simple no-JavaScript widget to show/hide element contents, optionally by clicking on its child <summary> element. It is fully accessible as the summary element is presented as a button to the accessibility tree.

Notes

  1. these elements are not supported in IE11 (who cares) or EDGE (pre chromium) but by the time J4 will be released it wont be an issue ;)
  2. If accepted we can do the same for text-filters

Testing instructions

npm i is needed "only" to check my bad scss ;) You can still test with patchtester you just wont get all the styling

Demo

perms

avatar brianteeman brianteeman - open - 29 Jun 2019
avatar brianteeman brianteeman - change - 29 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2019
Category Administration Language & Strings Templates (admin) Layout
avatar richard67 richard67 - test_item - 30 Jun 2019 - Tested successfully
avatar richard67
richard67 - comment - 30 Jun 2019

I have tested this item successfully on 1205779


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25366.

avatar Quy Quy - test_item - 30 Jun 2019 - Tested successfully
avatar Quy
Quy - comment - 30 Jun 2019

I have tested this item successfully on 1205779


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25366.

avatar Quy Quy - change - 30 Jun 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Jun 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25366.

avatar wilsonge wilsonge - close - 1 Jul 2019
avatar wilsonge wilsonge - merge - 1 Jul 2019
avatar wilsonge wilsonge - change - 1 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-01 20:13:23
Closed_By wilsonge
Labels Added: ? ? ?
avatar wilsonge
wilsonge - comment - 1 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 1 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment