Feeling Lucky
?
[#25360] - [4.0] Banners - nullable datetime fields
- Fixed in Code Base
- 17 Jul 2019
- Medium
- Build: 4.0-dev
- # 25360
- Diff
- brianteeman:fri1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16788 ....same as #24675 for contacts - I really just copied the work of others (someone has to)
Summary of Changes
some datetime fields should be nullable as default
- publish_up
- publish_down
- checked_out_time
Testing Instructions
test com_banners
Expected result
banners should works as before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql com_banners Front End Installation |
| Title |
|
||||||
| Labels |
Added:
?
|
||
brianteeman
- comment
- 29 Jun 2019
No not yet there is still more components
richard67
- comment
- 30 Jun 2019
@brianteeman There is also a column checked_out_time in the #__banner_clients table. Shouldn't that be done with this PR, too?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-17 20:09:55 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 17 Jul 2019
Thanks!
brianteeman
- comment
- 17 Jul 2019
Thanks
@brianteeman i guess #16788 cannot be closed for now.