[#25357] - [4.0] Keep Script/Style Declarations as an array instead of merge to one string
- Fixed in Code Base
- 4 Aug 2019
- Medium
- Build: 4.0-dev
- # 25357
- Diff
- Fedik:script-declaration-to-array
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Keep Script/Style Declarations as an array instead of merge to one string.
For long time JDocument merge all Script/Styles declarations to a single string, which not allow to use it for stuff like type="module" (which has import statement), or micro-data type="application/ld+json", and for other types that get broken when they merged.
This patch introduce a little B.C. (for extensions which use $doc->_script directly) but I think it not very critical, and better we do it now than never.
Additionally after little changes in #25301 this patch will allow to remove specific Script/Styles declarations without parsing whole $doc->_script/_style.
Testing Instructions
Apply the patch and make sure all still works as before.
Documentation Changes Required
This is potential B.C. and need to be described https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4
The Document::_script, Document::_style store Script/Styles declarations as an array, instead of string.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-04 22:34:21 |
| Closed_By | ⇒ | wilsonge |
Thanks!