[#25345] - [4.0] URL parameters lost when changing menu type
- Fixed in Code Base
- 28 Jun 2019
- Medium
- Build: 4.0-dev
- # 25345
- Diff
- SharkyKZ:comMenusModal
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25342.
Summary of Changes
Use current URL parameters when redirecting.
Testing Instructions
Make sure you have at least 2 site menu types.
Edit an article in backend.
In editor, click CMS Content -> Menu.
In the modal, change menu type (by selecting value in - Select Menu - field).
Expected result
Modal shows only a list of menu items.
Actual result
Modal shows entire site, with modules, sidebar, etc.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
Did you select a language under Filter Options?
I am speaking of a multilingual site. There is no filter for language in the modal as it is a forcedlanguage.
test is done via The Select field in the associations tab when editing a menu item
For example I edit a en-GB tagged menu item and I select the field for French
When switching menu in the modal to a menu containing ONLY de-DE tagged items, I may get
although I should get No Matching results
Hint: if you close the modal and then use the Select again, it is correctly filtered as $forcedlanguage is used for the items in the formerly selected menu.
So, maybe a state issue?
Hmm
I think I found the issue as it is also present in com_associations:
In com_associations:
Set the item type and then the language.
Then modify the Item type (for example select categories instead of articles)
The language gets back to Select language instead of keeping its original setting.
Therefore it is the same here:
If we modify the Menu then the language filter (in the Filter Options) is displayed again and forcedLanguage is no more in effect.
Imho jstools is at stake...
The language in Associations is reset intentionally:
Menu item issue seems related to the redirect.
Yes.
| Labels |
Added:
?
|
||
Should work now.
I have tested this item
Issue in description is solved with this PR.
Issue described in this comment is also solved.
Other issue described in this other comment is not solved. But I think that's not scope of this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25345.
This works for the 2 issues concerned.
Let's merge it.
NOTE: Found a bug with the Propagate functionality when 4 languages are concerned.
Will look further at it and create new issue. The bug is not restricted to Menu Items.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-28 05:33:54 |
| Closed_By | ⇒ | infograf768 |
Tks!
This solves the display to get only the component in the modal, but it does not solve the fact that the items displayed should be filtered by the target language.
Example below: we should display only the items tagged to French