? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
26 Jun 2019

Pull Request for Issue #25336.

Summary of Changes

Replaces call to non-existing method. Also adds component status badge from #25197.

Testing Instructions

Edit an article in backend.
In editor, click CMS Content -> Menus.

Expected result

Modal with menu items show up, menu item status correctly shown.

Actual result

Error in modal:

Recoverable fatal error: Object of class Joomla\Component\Menus\Administrator\Service\HTML\Menus could not be converted to string in libraries\src\HTML\HTMLHelper.php on line 149

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 26 Jun 2019
avatar SharkyKZ SharkyKZ - change - 26 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jun 2019
Category Administration com_menus
avatar SharkyKZ SharkyKZ - change - 26 Jun 2019
Title
Error in com_menus modal layout
[4.0] Error in com_menus modal layout
avatar SharkyKZ SharkyKZ - edited - 26 Jun 2019
avatar SharkyKZ SharkyKZ - change - 26 Jun 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 26 Jun 2019
avatar uglyeoin uglyeoin - test_item - 26 Jun 2019 - Tested successfully
avatar uglyeoin
uglyeoin - comment - 26 Jun 2019

I have tested this item successfully on 204ae6d

Tested successfully, everything appears to be fixed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25338.

avatar uglyeoin
uglyeoin - comment - 26 Jun 2019

I have tested this item successfully on 204ae6d

Tested successfully, everything appears to be fixed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25338.

avatar uglyeoin
uglyeoin - comment - 26 Jun 2019

This may be for a different pull request but there is still a problem as far as I can see on the front end.

The requested page can't be found.

This isn't just for menus but for all of the editor plugins.

avatar brianteeman
brianteeman - comment - 26 Jun 2019

@uglyeoin there are multiple open issues for that - unfortunately no one seems interested in fixing it

avatar uglyeoin
uglyeoin - comment - 26 Jun 2019

@brianteeman keep the faith, I'm sure someone will. I suspect it's beyond me or else I would try to help.

avatar Quy Quy - test_item - 26 Jun 2019 - Tested successfully
avatar Quy
Quy - comment - 26 Jun 2019

I have tested this item successfully on 204ae6d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25338.

avatar Quy
Quy - comment - 26 Jun 2019

I have tested this item successfully on 204ae6d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25338.

avatar Quy Quy - change - 26 Jun 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Jun 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25338.

avatar Quy
Quy - comment - 26 Jun 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25338.

avatar Quy
Quy - comment - 27 Jun 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25338.

avatar infograf768 infograf768 - change - 27 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-27 06:41:12
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 27 Jun 2019
avatar infograf768 infograf768 - merge - 27 Jun 2019
avatar infograf768
infograf768 - comment - 27 Jun 2019

Tks

Add a Comment

Login with GitHub to post a comment