User tests: Successful: Unsuccessful:
Scenario:
extension: com_xlz
extension language folder: ROOT/components/com_xlz/language
when the language filter plugin is enabled, the language files already loaded for the component com_xyz are completely removed, that's due to the missing basepath when the function JLanguage->load is called.
Pull Request for Issue # .
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Please follow Joomla Coding Standards: https://developer.joomla.org/coding-standards/php-code.html
dear co-founder, test it
Without this PR and testing the docman component
The default site loaded
Loaded : JROOT\components\com_docman\language\en-AU\en-AU.com_docman.ini
and when switched to french the site loaded
Loaded : JROOT\components\com_docman\language\fr-FR\fr-FR.com_docman.ini
So what am I supposed to test
PS Not relevent here but its Always best to make sure you are using the correct api docs
@bygiro Brian is right, the link to the API doc in the description is for Joomla 2.5.
In addition, you provide no information about your environment (Joomla version, PHP versio) and so on. What do you think why we have that head lines in our issue template? Do you think we do that just to have some nice and fancy head lines e.g. for testing fonts?
If I was a maintainer of this repository, I would assume you were using J 2.5 (because of your API doc link and the missing environment info), and I would close this issue with a hint that you should update your outdated 2.5 to 3.9.8.
But thanks god I am not a maintainer, only a contributor.
From my understanding of the languagefilter plugin, it is executed before the language files for any extension is loaded. So my first question would be what exactly you do to face this issue.
Also, please provide testing instructions to replicate the issue. If it can't be replicated in core, please provide an example extension.
I recommend that this is closed on Monday if the requested information is not supplied
@HLeithner See Brian's comment above. Please set a reminder in your calendar ;-)
@richard67 please remind me as @HLeithner has enough to do as Release Lead.
@franz-wohlkoenig Ah, ok. I thought it was on release lead level to decide if a PR is closed by someone else than the author. I'll ping you on Monday evening after work, CEST - MESZ.
Ups, i was on an Issue, but its a PR ...
Or close it now and reopen it if/when additional information is provided.
Yes, is a PR, but not clear if valid, information missing, and even if valid it is in my opinion the wrong way to fix that issue (if there is an issue). And the author does not give a cent on our code style, even if drone and Quy do the work for checking it.
Folks - please remember that this is not a chat room. Some of us get an email for every comment. So please keep the comments to the code and use glip or something else to chat. (and don't reply to this!!)
This code makes no sense at all.
I am closing now. Can be reopened if the OP adds here a zip of the component AND precise testing instructions.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-29 06:11:21 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
BTW, I did a simple test:
Moved the fr-FR.com_content.ini
file to a newly created com_content/language/fr-FR/
Debug lang on shows
Translation
Non chargé = Not Loaded
Chargé = Loaded
**Non chargé** : JROOT/language/fr-FR/fr-FR.com_content.ini
**Chargé** : JROOT/components/com_content/language/fr-FR/fr-FR.com_content.ini
All is perfectly fine.
I can't believe this is correct