[#25319] - [4.0] Creating language overrides - accessibility issues
- Fixed in Code Base
- 8 Jul 2019
- Medium
- Build: 4.0-dev
- # 25319
- Diff
- brianteeman:mon2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
This PR addresses various accessibility issues when creating new language overrides. This includes
- a button should be a button
- search input must have a label
- remove invalid description reference
- move message "refreshing cache" so it is not obscured by dropdown
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages |
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
Hi guys,
what I don't understand is why the "Search for" must be a dropdown menu (just for 2 values: Value and Constant)...
Why not have just a selector button (left / right > Value / Constant) on the left or above the "Search" field ?
Good point. I will update the pr.
Updated thanks - for the suggestion
Creating new override:
Clicking on the Search button when the field is empty redirects to administrator/index.php?option=com_languages&id=
In 3.x and before this patch in 4.x it just highlights the field itself.
Also: Search button is totally broken even when the field is not empty.
Looks related to the change to the searchtype field.
Using type radio instead of list
Correction: It looks also related to class="switcher"
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25319.
Further test show that the overrider.js is impacted by this change in type.
var formSearchType = document.getElementById('jform_searchtype');
and
this.states.searchType = formSearchType.value || 'value';
do work when type is list.
no more when type is radio.
I have reverted the change to the switcher from the list. I can see how the js breaks but I dont have the skills to fix it. It can always be addressed in its own PR as it doesnt affect a11y which was the aim of this PR
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25319.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25319.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25319.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25319.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-08 16:37:16 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks.
Thanks
I have tested this item✅ successfully on f6a4c62
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25319.