? ? Success

User tests: Successful: Unsuccessful:

avatar richard67
richard67
23 Jun 2019

Pull Request for Issue #25293 .

Summary of Changes

This PR fixes 2 problems coming from PR #24595 :

  1. The database schema checker can't handle removing and adding back an index with the same name. Since that index was not useful anyway, this PR changes the schema updates from PR #24595 and the installation joomla.sql so this index is not added back, but 2 useful indexes are added istead. For details on these changes see #25293 (comment).
  2. This PR also fixes the typo ALTER TABLE "#__template_style" instead of ALTER TABLE "#__template_styles" in the schema update from PR #24595 for postgresql.

Testing Instructions

  1. Install current staging and check database view in backend. Result: See section "Actual result" below.
  2. Use "fix" button: Result: does not help. You will end in a toggling of database error "inxed should exist" and "index should not exist" with every click on the "fix" button.
  3. Apply patch of this PR e.g. with Patchtester component.
  4. Refresh database view. Result three errors: 1. index idx_home should not exist, 2. idx_client_id should exist, and 3. idx_client_id_home should exist.
  5. Use "fix" button. Result: See section "Expected result" below.
  6. Remove configuration.php and clear database content e.g. with MyPhpAdmin and repeat clean installation. Result: See section "Expected result" below.

For Postgresql the number of errors shown in step 4 and for the actual result is different because of the typo in the schema update for postgresql without this PR, but at the end the result will be the same: Fix button in step 5 fixes it, and after new install with this PR applied there are no errors.

Expected result

No database errors.

Actual result

1 error: Table 'xyz_template_styles' should not have index 'idx_home'. (From file 3.9.8-2019-06-15.sql.)

Documentation Changes Required

None.

avatar richard67 richard67 - open - 23 Jun 2019
avatar richard67 richard67 - change - 23 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2019
Category SQL Administration com_admin Postgresql MS SQL Installation
avatar richard67 richard67 - change - 23 Jun 2019
Labels Added: ?
avatar richard67 richard67 - change - 23 Jun 2019
The description was changed
avatar richard67 richard67 - edited - 23 Jun 2019
avatar richard67
richard67 - comment - 23 Jun 2019

Appveyor failure seems not to be related to this PR.

avatar richard67 richard67 - change - 23 Jun 2019
The description was changed
avatar richard67 richard67 - edited - 23 Jun 2019
avatar richard67
richard67 - comment - 23 Jun 2019

@alikon Please test as soon as you find time. Check also the links in #25293 (comment) for my changes on the indexes.

avatar richard67
richard67 - comment - 24 Jun 2019

@HLeithner I think this is a release blocker.

avatar richard67
richard67 - comment - 24 Jun 2019
avatar richard67 richard67 - change - 24 Jun 2019
The description was changed
avatar richard67 richard67 - edited - 24 Jun 2019
avatar richard67 richard67 - change - 24 Jun 2019
The description was changed
avatar richard67 richard67 - edited - 24 Jun 2019
avatar Quy Quy - test_item - 24 Jun 2019 - Tested successfully
avatar Quy
Quy - comment - 24 Jun 2019

I have tested this item successfully on c21850b

Tested MySQL.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25299.

avatar Quy
Quy - comment - 24 Jun 2019

I have tested this item successfully on c21850b

Tested MySQL.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25299.

avatar alikon alikon - test_item - 24 Jun 2019 - Tested successfully
avatar alikon
alikon - comment - 24 Jun 2019

I have tested this item successfully on c21850b

on postgresql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25299.

avatar alikon
alikon - comment - 24 Jun 2019

I have tested this item successfully on c21850b

on postgresql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25299.

avatar richard67
richard67 - comment - 24 Jun 2019

@Quy Thanks for testing. Could you add the RTC label? Nicola doesn't have that privilege anymore.

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Jun 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Jun 2019

Status "Ready To Commit".

avatar richard67
richard67 - comment - 24 Jun 2019

Thanks

avatar HLeithner
HLeithner - comment - 25 Jun 2019

thx

avatar HLeithner HLeithner - change - 25 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-25 11:59:52
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 25 Jun 2019
avatar HLeithner HLeithner - merge - 25 Jun 2019
avatar richard67
richard67 - comment - 25 Jun 2019

Thanks

Add a Comment

Login with GitHub to post a comment