guess its for #25286

@franz-wohlkoenig yes - I updated op. created the pr from my phone so easy to mistype

Maybe adding a check if user.css exists before including it?

Updated branch to make drone run

I have tested this item ✅ successfully on 774be4f

user.css is included in 404 error page after applying patch. Thanks.

I have tested this item ? unsuccessfully on 774be4f

With this PR applied, I get a 404 for the user.css when watching network traffic in developer tools of browser. It needs a check if the file exists before including it. This is different to the index.php and the offline.php, where JHtml::_('stylesheet', 'user.css' ... is used, which does that job for us.

I am a new to these testings, so I might have missed the mark, be patient, but I confirm the user.css is loaded after applying the patch and the site-title class rule I defined as an example is changing the font-size on the 404 error page.

And what if the user.css does not exist, which is the case on a standard Joomla 3.9.x? In this case you get an additional 404.

Understood. I also get a second 404 when user.css is not included.

made a small change - please retest

I have tested this item ✅ successfully on c51af2a

I have tested this item ✅ successfully on c51af2a

I have tested this item ✅ successfully on c51af2a

If user.css is included, the css rules are successfully added to the 404 page.
If user.css is missing, it doesn't generate another 404 error code.

I have tested this item ✅ successfully on c51af2a

RTC

@Quy The other pages use JHTML to add head links while error.php adds them directly. JHTML seems to include a check if the file exists, therefore there no extra check.

I think it is by design that the error page doesn’t use JHTML.

For consistency please use file_exists