User tests: Successful: Unsuccessful:
Right now, when reporting stats for MariaDB users the CMS sends either a version string like "10.1.29-MariaDB" or "5.5.5-10.1.29-MariaDB" to the stats server when reporting data, which through the sanitization routines the latter ends up in an entry being tracked as "5.5.5". In order to better track MariaDB usage, this pull request changes the string sent forward in the "5.5.5-10.1.29-MariaDB" case so that it is the MariaDB version number only (i.e. 10.1.29) without any of the extra cruft (note, the "10.1.29-MariaDB" case does get correctly sanitized down and stored as 10.1.29; the stats server's sanitization step for version strings basically removes everything after a SemVer compliant <major>.<minor>.<patch>
matching segment, this is what removes the stability bit from the CMS version, or changes something like "5.5.9-1ubuntu4.11" into "5.5.9", and if you were using a Google Cloud SQL database their "5.7.14-google-log" string would be stored as "5.7.14").
This utilizes the regex check from Doctrine that was referenced in #25245 (comment)
Apply the patch to a Joomla installation which uses a MariaDB backend. Then, check the data that the stats plugin will send to the server (you can see this info on the "System - Joomla! Statistics" plugin's edit screen). Pre-patch, the database version should be whatever it is now; post-patch, if it has the "5.5.5-" prefix and "-MariaDB" suffix, it should be only the MariaDB version string (the stuff in the middle of the *fix
bits).
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
I have tested this item
Before:
DB Version 5.5.5
After:
DB Version 10.3.15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25281.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-23 15:31:42 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
I have tested this item✅ successfully on e31230c
Before:
After:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25281.