[#25276] - [4.0] Update the AppVeyor badge to project changes
- Fixed in Code Base
- 20 Jun 2019
- Medium
- Build: 4.0-dev
- # 25276
- Diff
- richard67:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25274 .
Summary of Changes
Correct the appveyor badge for 4.0-dev:
- Changed
project/joomla/joomla-cmstoproject/release-joomla/joomla-cms. - Changed token.
Thanks to @blastoise186 for reporting that issue.
Testing Instructions
Check colour of the AppVeyor badge.
Click the AppVeyor badge on README.md.
Expected result
Colour fits to current build status for 4.0-dev.
After click, AppVeyor activity shown for the latest commits.
https://github.com/richard67/joomla-cms/blob/patch-2/README.md
Actual result
Colour fits to current build status in neolithicum.
AppVeyor activity shown for commits from 9 months ago and older.
https://github.com/joomla/joomla-cms/blob/4.0-dev/README.md
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
I have tested this item
As with #25275 the AppVeyor Badge correctly directs a user to /release-joomla/joomla-cms
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25276.
Please confirm that the URL will be the same for J3 and J4.
Yes, the URL was and still is the same, so when you click the link, you see in both cases commit history for all branches together. But the link for the SVG is different, and so the badge has the right color depending on branch. It was like that also before this PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25276.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25276.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25276.
AppVeyor appears to have been configured to process all the branches under the same Project, and it doesn't appear to distinguish between them for the tokens which are being used.
While there is a way to separate the badges for multiple branches according to the docs, I think that would just cause more problems as branches get moved around. I also note that the badges for the other CI's are generic for the whole project.
Yeah, those badges are confusing, color for branch but activity list for all. That's why I did not notice the problem fixed by this PR when recently testing other changes on badges, and I think that's the reason why other people haven't noticed those errors with the badges form months if not for years.
Thanks for helping out though!
On the plus side, it does at least look like keeping the AppVeyor Badges updated in the future would be a simple case of changing the branch that the badge icon points to, provided the project isn't moved to a new location
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-20 01:52:51 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Cheers guys!
Cheers and thanks
@blastoise186 Could you test this PR and mark the test result on https://issues.joomla.org/? You can use the links in the description for testing.