J4 Issue ?
avatar brianteeman
brianteeman
19 Jun 2019

every article has two input fields in the publishing tab
image
image

Guess what both have the same field name="xreference"
The first is saved in the json field 'metadata'
The second is saved in its own dedicated field

I can't see anywhere that they are used in com_contact
the code for this was added in 1.6 by @infograf768

=====
contacts does not have an input field but there is one in the database.
This time there is some code that references it in the store function but I don't see how you could ever store anything if there is no input. This code was added with #29088 by @mbabker

// Set xreference to empty string if not set
if (!$this->xreference)
{
$this->xreference = '';
}

======
newsfeeds does have an input field and a database field
image

but i cant find any reference at all in the code to see if it is used

=====
There are various other places that get the field in a query for example but then dont do anything with it. To me this is all some legacy code that has lost the connection to whatever it used to do and should be removed. No point keeping and updating code that doesnt do anything

avatar brianteeman brianteeman - open - 19 Jun 2019
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jun 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 19 Jun 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Jun 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 19 Jun 2019
avatar Quy
Quy - comment - 19 Jun 2019

You reported this before #17173. Sorry I don't have an answer.

avatar brianteeman
brianteeman - comment - 19 Jun 2019

Yes I know I am trying again.

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jun 2019
Status New Discussion
avatar brianteeman
brianteeman - comment - 11 Jul 2019

Surely someone must care that we have legacy code that no one knows what its for polluting the cms

avatar Quy
Quy - comment - 11 Jul 2019
avatar brianteeman
brianteeman - comment - 11 Jul 2019

Well that says to me that this field is completely useless now

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2019

Closed as having Pull Request #25524

avatar franz-wohlkoenig franz-wohlkoenig - close - 11 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-07-11 17:26:51
Closed_By franz-wohlkoenig

Add a Comment

Login with GitHub to post a comment