? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Jun 2019

Update the code so that it actually works

Pull request for #24861

Make layout match similar forms

Improve accessibility by using buttons for buttons

As far as I can tell it should be called "Batch Update Selected URL(s)" not "new URL(s)" - Based on the key being COM_REDIRECT_BATCH_UPDATE_WITH_NEW_URL I think it was supposed to be "batch update WITH new URL". I believe the proposed change is more accurate as you have to select redirects before they can be updated

avatar brianteeman brianteeman - open - 17 Jun 2019
avatar brianteeman brianteeman - change - 17 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2019
Category Administration com_redirect Language & Strings
avatar brianteeman brianteeman - change - 17 Jun 2019
Labels Added: ? ?
avatar Quy
Quy - comment - 18 Jun 2019

I have tested this item successfully on c4d6c36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25247.

avatar Quy Quy - test_item - 18 Jun 2019 - Tested successfully
avatar travisrisner
travisrisner - comment - 18 Jun 2019

I have tested this item successfully on c4d6c36

avatar Quy Quy - change - 18 Jun 2019
The description was changed
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 Jun 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25247.

avatar joomla-cms-bot joomla-cms-bot - edited - 18 Jun 2019
avatar joomla-cms-bot joomla-cms-bot - edited - 18 Jun 2019
avatar roland-d roland-d - change - 23 Jun 2019
Labels Added: ?
avatar roland-d
roland-d - comment - 23 Jun 2019

@brianteeman When testing this I do not get a modal but the form opens up below the button:
image

This is not how it is supposed to work right? I do not have any JavaScript errors.

avatar Quy
Quy - comment - 23 Jun 2019

It is an accordion and behaves just like in J3.

avatar brianteeman
brianteeman - comment - 23 Jun 2019

It is the intended behaviour (dont' know why it was created like that)

avatar wilsonge wilsonge - change - 23 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-23 16:34:38
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 23 Jun 2019

Thanks!

avatar brianteeman
brianteeman - comment - 23 Jun 2019

Thanks

Add a Comment

Login with GitHub to post a comment