[#25205] - [4.0] Fixing children when changing menu of menu item
- Fixed in Code Base
- 23 Jun 2019
- Medium
- Build: 4.0-dev
- # 25205
- Diff
- Hackwar:patch-8
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #7579.
Summary of Changes
When a menu item has child-menu items and its menu is being changed, the children should change their menu as well. Right now this is not the case.
Testing Instructions
- Be sure that you have 2 menus.
- Create a menu item in one menu and another item in the same menu as a child of the first.
- Edit the first menu item and change the menu that this item belongs to.
Expected result
The menu item and all its children are changed to the new menu and remain in their former structure.
Actual result
The first menu item is changed over, the children stay in the original menu.
This fixes a really old issue (#7579), so please help out to test this and fix this long term issue.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25205.
| Labels |
Added:
?
|
||
Once I get a J4 install up and running I will test this
I have tested this and I have some questions.
Scenario:
Menu 1.
Parent 1
- Child 1
-- Child 3
Menu 2
Parent 2
Batch move Child 1 to Parent 2. Works.
Go into Child 1 and move to Parent 1 using sidebar menu (not batch). Leaves child 2 behind but they are still part of parent 2.
Move Child 1 from Parent 1 BACK to Parent 2. Child 2 now becomes a child of Child 1 again.
This is confusing and I'm not sure it's the right action. Can someone else please sanity check my work?
Can someone else please sanity check my work?
Well, first of all your menu strtucture show "Child 3" and not "Child 2", but in the text below you write about "child 2" and not "child 3" => inconsistent => Gives a bad impression about sanity and carefulness.
@uglyeoin Beside the inconsistency mentioned above, it seems you misinterpreted the purpose of this PR.
You write something about "Batch copy .. works". But that is not subject of this PR.
This PR deals with moving a menu item and its children from one menu to another by editing the menu item properties and there changing the menu to which the menu item belongs to.
It does not deal with changing the parent menu item for that menu item, neither in batch nor in editing menu items.
@Hackwar Correct me if I'm wrong.
Sorry my bad, I haven't added the patch. Rushing too much. I will try again
No problem.
@uglyeoin If you want to test on current 4.0-dev branch and so pulled the latest changes, made a Edit: PR #25261 is merged, so after pulling latest changes and running composer install and an npm install, and then want to start to set up the site and see only an empty page: Is a know issue, PR is in progress: See #25261 .composer install and npm install , installation should work.
I have tested this item
Tested again after recent commit. Still works.
Easy to test with Patchtester Component and with Blog Sample Data installed.
With the PR applied, changed menu for "Working on Your Site" from "Author Menu" to "Main Menu Blog" in the menu item edit view and then "Save & Close".
Result: Menu items for "Main Menu Blog" are shown in the menu items list. The menu item and the 2 children "Site Settings" and "Template Settings" have been moved to that menu.
(Without the PR, the child items were left alone and not moved with the parent).
Note that there is the same issue when in the menu item edit view changing the parent menu item of a menu item which has children. This is not subject of this PR here but should be corrected with another, future PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25205.
I have tested this item
Tested again after recvent commit. Still works.
Easy to test with Patchtester Component and with Blog Sample Data installed.
With the PR applied, changed menu for "Working on Your Site" from "Author Menu" to "Main Menu Blog" in the menu item edit view and then "Save & Close".
Result: Menu items for "Main Menu Blog" are shown in the menu items list. The menu item and the 2 children "Site Settings" and "Template Settings" have been moved to that menu.
(Without the PR, the child items were left alone and not moved with the parent).
Note that there is the same issue when changing in the menu item edit view the parent menu item of as menu item which has children. This is not subject of this PR here but should be corrected with another, future PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25205.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25205.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
@Hackwar Question: Should the lft and rgt values also be changed when moving a menu item with children from one to the other menu like with this PR? And when moving a menu item with children from 1 to another parent menu item as I wrote above to be done for another PR? Or will lft and rgt be updated when saving the changed menu item? I hope that will be the case.
No, it doesn't have to change the lft and rgt values. Further issues should be fixed in other PRs.
| Labels |
Added:
?
|
||
@richard67 that's weird. But a bit lucky that I discovered it. I have created a new issue here #25270
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-23 08:40:51 |
| Closed_By | ⇒ | roland-d |
Thank you.
@RoterNagel @justinherrin please test.