? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
12 Jun 2019

Pull Request for Issue #24721

Summary of Changes

Using the override administrator/components/com_menus/Service/HTML/Menus.php for jgrid.published in the Menu items Manager.
In 3.x this is done by /administrator/components/com_menus/helpers/html/menus.php

This will display again the correct Status icon for System Links menu items as well as using the specific tip for each menu item icon.

NOTE: This will not modify the display of the tooltip as this requires a specific PR for jgrid.

Testing Instructions

Make sure you have created a System Links menu item (URL, Heading, Separator, Alias).

Display the Menu Items Manager and try to modify the status of these menu items
Although they may be Published, the icon the grey cross
If one uses the toolbar to Unpublish the item, the icon displays a black folder instead of the grey cross

The tip is the default tip used by jgrid and NOT the specific menu items tip.

Patch and test again.

Before patch

For a URL menu item
Screen Shot 2019-06-12 at 11 47 36

For a non system links menu item
Screen Shot 2019-06-12 at 11 47 52

After patch

For a URL menu item:
The icon reflect the Published status and the specific tip
Screen Shot 2019-06-12 at 11 43 17

and for a non system links menu item, the specific tip
Screen Shot 2019-06-12 at 11 43 05

Note2

I have not modified the existing language strings for the tips. They represent an action and not the existing status. This can be discussed elsewhere.

avatar infograf768 infograf768 - open - 12 Jun 2019
avatar infograf768 infograf768 - change - 12 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2019
Category Administration com_menus
avatar infograf768
infograf768 - comment - 12 Jun 2019

The other solution is to change the Model and give up the overrides. Would still need some changes in Jgrid to display the tip ok

avatar 810
810 - comment - 12 Jun 2019

I have tested this item successfully on 4bec549


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25185.

avatar 810 810 - test_item - 12 Jun 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 12 Jun 2019

This breaks display for expired items.

avatar infograf768
infograf768 - comment - 12 Jun 2019

@SharkyKZ
yes I know. I am able to solve the issue only if we forget about component enabled or not.
In that case we will get
Screen Shot 2019-06-12 at 16 50 49

Where Newsfeeds component is disabled-> shows Unpublished icon and no useful tip.
Screen Shot 2019-06-12 at 16 55 00

Except if someone finds a trick, we have to choose between both ways.

avatar brianteeman
brianteeman - comment - 12 Jun 2019

The "tooltips" have always been a confusing mess of action and status #9359

avatar infograf768 infograf768 - change - 12 Jun 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 13 Jun 2019

Found a way to display a badge when component is disabled while keeping expired icon.
Closing this PR as I will propose a new solution.

avatar infograf768 infograf768 - change - 13 Jun 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-06-13 11:47:34
Closed_By infograf768
avatar infograf768 infograf768 - close - 13 Jun 2019
avatar infograf768
infograf768 - comment - 13 Jun 2019

Please test this new one
#25197

Add a Comment

Login with GitHub to post a comment