User tests: Successful: Unsuccessful:
Pull Request for Issue #24721
Using the override administrator/components/com_menus/Service/HTML/Menus.php
for jgrid.published
in the Menu items Manager.
In 3.x this is done by /administrator/components/com_menus/helpers/html/menus.php
This will display again the correct Status icon for System Links menu items as well as using the specific tip for each menu item icon.
NOTE: This will not modify the display of the tooltip as this requires a specific PR for jgrid
.
Make sure you have created a System Links menu item (URL, Heading, Separator, Alias).
Display the Menu Items Manager and try to modify the status of these menu items
Although they may be Published, the icon the grey cross
If one uses the toolbar to Unpublish the item, the icon displays a black folder instead of the grey cross
The tip is the default tip used by jgrid
and NOT the specific menu items tip.
Patch and test again.
For a non system links menu item
For a URL menu item:
The icon reflect the Published status and the specific tip
and for a non system links menu item, the specific tip
I have not modified the existing language strings for the tips. They represent an action and not the existing status. This can be discussed elsewhere.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_menus |
I have tested this item
This breaks display for expired items.
@SharkyKZ
yes I know. I am able to solve the issue only if we forget about component enabled or not.
In that case we will get
Where Newsfeeds component is disabled-> shows Unpublished icon and no useful tip.
Except if someone finds a trick, we have to choose between both ways.
Labels |
Added:
?
|
Found a way to display a badge when component is disabled while keeping expired icon.
Closing this PR as I will propose a new solution.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-13 11:47:34 |
Closed_By | ⇒ | infograf768 |
The other solution is to change the Model and give up the overrides. Would still need some changes in Jgrid to display the tip ok