[#25161] - [4.0] fix display of item association popover
- Fixed in Code Base
- 10 Jun 2019
- Medium
- Build: 4.0-dev
- # 25161
- Diff
- lavipr:fixTooltipPopover
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Since the tooltips are hidden by default (#24892) and are only displayed when the previous sibling element is focused in the DOM, tooltips that have the same role and are applied as popovers using bootstrap can no longer be displayed because they do not have a previous focusable sibling element as they are added at the end of the DOM. They differ in that they get the class '.show' when activated.
So, to fix the problem, the css statements do not apply to tooltips with the role that have the class 'show'.
I guess that's not the right solution? Now that I've discovered that #24899 is still working on the tooltips.
Should the bootstrap popover still be used or will the HTML also be adapted for associations?
Testing Instructions
Run npm i as a scss file changed.
Install at least two languages and install the multilingual sample Data. Go to a view where Associations are displayed, for example in Multilingual Associations.
Hover or focus on an item-association-language.
Expected result
The tooltip is displayed:
Actual result
No tooltip is displayed
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25161.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25161.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25161.
Not sure this is right either - our custom tooltips should probably be bound to a class AND the role rather than to all tooltips (potentially disrupting other frameworks). Merging for now as it fixes the immediate issue. But would be good to probably bind the css there to a class (cc @brianteeman )
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-10 22:59:55 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 55ec7df
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25161.