[#25158] - [4.0] Improve menu item access check
- Fixed in Code Base
- 10 Jun 2019
- Medium
- Build: 4.0-dev
- # 25158
- Diff
- HLeithner:menu-public-access-check
- Pending Hound Hound is busy sniffing around... Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
This PR optimizes the authorise function in the menu to not load an user object (and don't start a session if not needed) for menu items with the access level "public".
This PR in combination with PR #25152 using apcu (or any other session and cache handler except Database) and disabled session metadata brings Joomla! down to 0 database queries for cached pages.
Clearly not for all pages only for pages that doesn't require any user authentication.
Summary of Changes
Check if the menu item access level is public and return early if true.
Testing Instructions
Create menu items with different access levels.
Expected result
Nothing changes, menu is protected and visible as before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Guest level is also unauthenticated
You have to be logged in to have no guest level so the check needs the user object to validate if you are a guest or not.
Quy
- | Title |
|
||||||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-10 23:03:04 |
| Closed_By | ⇒ | wilsonge |
Side note, creating a session only if it's need can bring us down to no cookies which maybe helpful for gdpr checks.