[#25153] - Use joomla's constants instead of JPATH_ROOT in the namespace mapper
- Fixed in Code Base
- 10 Jun 2019
- Medium
- Build: 4.0-dev
- # 25153
- Diff
- wilsonge:feature/namespace-map
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Use JPATH_SITE, JPATH_ADMINISTRATOR, JPATH_API and JPATH_PLUGINS for the locations instead of the JPATH_ROOT. This is better for people placing things in custom locations and also reads a bit nicer:
'Joomla\\Component\\Content\\Site\\' => [JPATH_SITE . '/components/com_content/'],
'Joomla\\Component\\Content\\Api\\' => [JPATH_API . '/components/com_content/'],
'Joomla\\Component\\Content\\Administrator\\' => [JPATH_ADMINISTRATOR . '/components/com_content/'],
To test. Remove libraries/autoload_psr4.php and let it be regenerated with the new paths. Ensure nothing breaks
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Looks good to me:
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25153.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25153.
Need to debug. I re-ran it and it's reliably failing. So my guess is I've broken it somewhere :)
| Category | Libraries | ⇒ | Installation Libraries |
Fixed it. Apparently I messed up the path to the api directory in the installer application
Looks good now:
Pity that I did not see that in my previous diff.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25153.
In your previous diff it was correct. You only see it if you do a fresh install of Joomla and the installation app generates the file. in the administrator and site apps it was fine because the constants in the defines files there are correct.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-10 22:56:54 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Site modules now have
JPATH_ADMINISTRATORpath, e.g.