[#25145] - [com_fields] Fix/Improve checks for empty output in field groups
- Fixed in Code Base
- 25 Jun 2019
- Medium
- Build: staging
- # 25145
- Diff
- AndySDH:patch-8
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR improves checks for empty output when rendering a field as part of field groups. Some checks were already there but not thorough, and empty output could occur in rare cases.
This makes sure that a field that has an empty value or an empty output does not get displayed in all cases.
One check comes from the original subfields PR (https://github.com/joomla/joomla-cms/pull/22446/files#diff-02a314737553eb71a8516e925b220cce) that was postponed to Joomla 4.
Another extra check I added myself.
Testing Instructions
Not much needed really. Just double checks.
Expected result
Field with empty output should never display
Actual result
Field with empty output could be displayed in rare occurrences
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_fields |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145.
To merge in 3.9.8?
Edit: 3.9.9 now I guess :D
I wasn't too sure the suggested changes made much sense as there's no need to compare for data type when we are comparing to an empty string.
But ok, I applied them.
Reminder about this for 3.9.9
Reminder about this for 3.9.9
calling Release Lead @HLeithner to be sure.
thx
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-25 12:28:52 |
| Closed_By | ⇒ | HLeithner |
@AndySDH can you please mail me wohlkoenig.franz@gmail.com
@AndySDH can you please mail me wohlkoenig.franz@gmail.com
I did
Updated with @Quy suggestions, thanks!