J3 Issue ? ?
avatar uglyeoin
uglyeoin
8 Jun 2019

Steps to reproduce the issue

Turn error reporting to development
Use PHP 7.1

Expected result

No errors or warnings from core

Actual result

The above warning. Which I believe has been fixed in Simple Pie.

System information (as much as possible)

=============
System Information

php: Linux server5.softforge.co.uk 2.6.32-754.12.1.el6.x86_64 #1 SMP Tue Apr 9 14:52:26 UTC 2019 x86_64
dbserver: mysql
dbversion: 5.5.5-10.1.40-MariaDB
dbcollation: utf8_general_ci
dbconnectioncollation: utf8mb4_general_ci
phpversion: 7.1.29
server: Apache
sapi_name: cgi-fcgi
version: Joomla! 3.9.6 Stable [ Amani ] 7-May-2019 15:00 GMT
platform: Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
useragent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Additional comments

avatar uglyeoin uglyeoin - open - 8 Jun 2019
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Jun 2019
avatar uglyeoin
uglyeoin - comment - 8 Jun 2019

I think this just requires us to update Simple Pie. Here is the fix (I think). simplepie/simplepie#458


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25143.

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Jun 2019
Labels Added: J3 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 8 Jun 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Jun 2019
Status New Discussion
avatar brianteeman
brianteeman - comment - 9 Jun 2019

Joomla is using a very old version (1.3.1)
@HLeithner can this be updated? I see it is set in composer to use that specific version

avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Jun 2019
Labels Added: Information Required
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 9 Jun 2019
avatar HLeithner
HLeithner - comment - 9 Jun 2019

It seams version 1.5 is the last version supporting PHP 5.3 (at least they removed testing in 1.5.1).
Later version removed testing vor php 5.4 and 5.5, Version 1.4.3 is the version version including the patch, so I would suggest to upgrade to 1.4.3.

Joomla core seams not to use this at all and has it deprecated.

Does our policy say anything against this?

avatar mbabker
mbabker - comment - 9 Jun 2019

George purposefully didn't upgrade past 1.3.1 when converting the library to use Composer because there were no changelogs or other resources available to determine compatibility issues in newer versions of the library. So before someone goes and blindly runs a composer update they need to either find appropriate changelogs and release notes or do a manual review of the diff between 1.3.1 and whatever version is upgraded to.

avatar HLeithner
HLeithner - comment - 9 Jun 2019

so backporting the fix would be a quick solution but I have seen there is also a php 7.4 combat fix in 1.5.3.

avatar mbabker
mbabker - comment - 9 Jun 2019

Please don't start modifying files in libraries/vendor.

avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Jun 2019
Labels Removed: Information Required
avatar franz-wohlkoenig franz-wohlkoenig - unlabeled - 9 Jun 2019
avatar HLeithner
HLeithner - comment - 9 Jun 2019

I'm not planing to, only to find a solution... so a really quick look showed changes in the hashing function that would return different hashes.

At least the demo's didn't changed for 7 years. Anyway I will take a closer look but that will take sometime. If anyone else is welcome to do it.

Whats your suggestion if we find something incompatible to our version?

avatar mbabker
mbabker - comment - 9 Jun 2019

Either don't touch it because it's a third party library and the integration is deprecated anyway (nobody bothered updating MooTools after it was deprecated) or if you really feel that compelled to make changes then fork the library, make the changes, and change Joomla to use that forked repo as the install source (as that's the only solution that prevents unwanted revert of those changes anyway).

avatar HLeithner
HLeithner - comment - 9 Jun 2019

So won't fix is your suggestion then?

avatar mbabker
mbabker - comment - 9 Jun 2019

If you can't safely upgrade to a more recent version then yes.

avatar brianteeman
brianteeman - comment - 9 Jun 2019

The integration might be deprecated but is it really right to ship with an outdated library that 3pd are using

avatar mbabker
mbabker - comment - 9 Jun 2019

If it can't be safely upgraded then the better option is to not upgrade it. Same theoretical problem with any other external dependency.

avatar brianteeman
brianteeman - comment - 4 Feb 2020

@HLeithner anything happening here?

avatar HLeithner
HLeithner - comment - 13 Apr 2020

Since I'm not planing to fork simplepie and it's unused in core I would suggest that a extension developer upgrade include the version he/she needs.

If someone like to fork simplepie and maintain it for php 5.3 to php 8.1 I would include it in Joomla! but at this time I see here a won't fix.

avatar Quy Quy - change - 7 Oct 2020
Labels Added: ?
avatar Quy Quy - labeled - 7 Oct 2020
avatar HLeithner HLeithner - change - 21 Nov 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-11-21 18:50:33
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 21 Nov 2020

Won't except someone is willing to fork it to joomla-backports and maintain it.

avatar HLeithner HLeithner - close - 21 Nov 2020

Add a Comment

Login with GitHub to post a comment