I have tested this item ✅ successfully on ae8d731

I have tested this item ✅ successfully on ae8d731

Accessibility golden rule is to never rely on just one visual indicator so this PR adds an icon

Is the header with the string "Error"/"Message" etc not enough of a visual indicator?

EDIT: Genuine question - after re-reading comes across a bit snarky

@wilsonge Yes the header could be considered enough. However I think this is still a good idea because

1. It has been shown that people will cognitive issues or dyslexia benefit from the use of icons
2. It adds some consistency with the inline images
3. I still hold out hope that we will drop/reduce these popup messages

Can you elaborate on the inline image consistency?

So my gut on this is right now is that it clutters the UI. It definitely makes more sense if the alerts weren’t pop ups and I’d happily reconsider this if/when that happens.

Can you elaborate on the inline image consistency?

See #25116

So my gut on this is right now is that it clutters the UI.

Says the man who likes orange ;)

Seriously though - up to 8% of users are dyslexic and it is established that the use of visuals are useful to reinforce concepts.

I have tested this item ✅ successfully on 86a52cb

@Quy can you please retest?

@franz-wohlkoenig Only commit after @Quy 's test was a clean update from base branch without any changes. So it could be set to RTC.

Status "Ready To Commit".

@brianteeman @wilsonge this is wrong!!! You're coupling the alerts system to another dependency (font awesome) and worst part you don't even load that dependency correctly, eg in the layout BUT expecting that the template will always load font awesome.

These kinds of code and the underlying assumptions are the blocking elements that make Joomla a really bad option for any front end developer.

The annoying part here is that @C-Lodder already provided the correct code for this part here: joomla-projects/custom-elements#99 (comment)
so a pretty straight forward question from me: WHY ARE YOU CONSTANTLY IGNORING FRONT END DEVELOPERS?

Thank you for you constructive comment. It's not correct at all but hey ho I guess you are always right

I will ignore the part about I'm always right and ask you a very simple question why it's not correct at all?

• Do you or not coupling to Font awesome without even loading that asset in that JLayout?
• Do you expect that all the Joomla created sites will load font awesome?

Address my honest concerns here and please stop bullying people...

This is in the admin

@brianteeman you must be joking right?
This file:
https://github.com/joomla/joomla-cms/pull/25135/files#diff-539fd950161fba0becf74d57599e5d39
is used in both front end and back end. Same goes for all the fields. That was one of the main reasons I was trying to decouple all fields from Bootstrap AND Font Awesome in order to provide a neutral base for any front end framework...

@dgrammatiko in this case is right - it is shared between frontend and backend (for example save the frontend global config param). Is there a reason charlie's comment on that PR didn't work - because bearing in mind it is used in the frontend - it's probably a better solution

I have not tested this item.

Resetting test result to not tested until discussion solved. Will test again then.

It can be done that way. I didn't because it can't be used the same way for
the inline messages and I assumed it was better to use the same method.
Feel free to submit a pr

On Sun, 9 Jun 2019, 13:23 Richard Fath, notifications@github.com wrote:

I have not tested this item.

Resetting test result to not tested until discussion solved. Will test
again then.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/tracker/joomla-cms/25135.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/25135?email_source=notifications&email_token=AAJ4P4KL5ONH3TITDDLHMTLPZTY43A5CNFSM4HVBNY22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIJCYY#issuecomment-500207971,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ4P4I7WNHCPJUQ3NYIAGLPZTY43ANCNFSM4HVBNY2Q
.

Who shall do the PR? If nobody else wants, I will try, but I want to avoid to try it while someone else does it at the same time. Credits should go to @C-Lodder anyway.

@richard67 Please go for it.

@Quy Ok, am working on it.

@Quy Hmm, seems the changes which @C-Lodder suggests have to be done in the custom elements repository and not here, or am I wrong?

@brianteeman I see there is already an issue for that in the custom elements repo: joomla-projects/custom-elements#99, is that right? Or am I wrong and it is not related?

Yes in the CE repo.

Not sure if I get it: Should the same changes as @C-Lodder proposed for the custom elements repo also be done here in file layouts/joomla/system/message.php ?

My understanding is that changes in CE will be ported here.

Hmm, then it may take some time. Have to prepare for first time contribution to the custom elements.