Feeling Lucky
?
[#25129] - [4.0] Cleanup the View files com_banners
- Fixed in Code Base
- 26 Jun 2019
- Medium
- Build: 4.0-dev
- # 25129
- Diff
- roland-d:feature/com-banners-view-model
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is the next step in cleaning up the view files and adhering to coding standards as well as making the views more usable by the IDE by removing the magic getter.
Testing Instructions
- Go to Components -> Banners -> Banners
- Make sure Banners work as before
- Go to Components -> Banners -> Clients
- Make sure Clients work as before
- Go to Components -> Banners -> Tracks
- Make sure Tracks work as before
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 24 Jun 2019
Can you fix the conflicts here please
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-26 10:55:50 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 26 Jun 2019
Thanks!
Again holding on this because of the void typehint until the 7.2 min version gets released - but approved once done