? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Jun 2019

Pull Request for Issue #23737 .

Subject to an answer to #25125 these are the last two files to correct to complete and close that issue

Testing Instructions

Code review

108175e 5 Jun 2019 avatar brianteeman menu
avatar brianteeman brianteeman - open - 5 Jun 2019
avatar brianteeman brianteeman - change - 5 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jun 2019
Category Administration com_menus Modules
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Jun 2019

not closing now #23737 is correct?

avatar brianteeman
brianteeman - comment - 5 Jun 2019

@franz-wohlkoenig yes it is waiting an answer on #25125 (I created a new issue because no one seems to look at latest updated issues)

7134d59 5 Jun 2019 avatar brianteeman typo
avatar brianteeman brianteeman - change - 5 Jun 2019
Labels Added: ?
avatar Quy
Quy - comment - 5 Jun 2019

I have tested this item successfully on 7134d59


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25126.

avatar Quy Quy - test_item - 5 Jun 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Jun 2019

Thanks to @SharkyKZ correctly pointing out that the multilingual status link should be a button as well which I have now done and to @Quy for fixing the styling.

Note that the style of that button now looks wrong but I am not wasting my time fixing that as it will probably get changed by the "new" template anyway

avatar Quy
Quy - comment - 6 Jun 2019

I have tested this item successfully on b92cd29


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25126.

avatar Quy Quy - test_item - 6 Jun 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 8 Jun 2019

Updating branch to try and retrigger appveyor

avatar wilsonge wilsonge - change - 8 Jun 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-08 21:06:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Jun 2019
avatar wilsonge wilsonge - merge - 8 Jun 2019
avatar brianteeman
brianteeman - comment - 8 Jun 2019

thanks

Add a Comment

Login with GitHub to post a comment