[#25124] - [4.0] Transition of Joomla's wrapper module and component from HTML4 to HTML5 - REVISION
- Closed
- 9 Jun 2019
- Medium
- Build: 4.0-dev
- # 25124
- Diff
- BaleshSrle:4.0-dev
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Revision for Pull Request #20212 .
Summary of Changes
By revisiting my pull request and using site w3schools.com as guide, I made a solution to merge HTML4 and HTML5 elements by leaving Width and Height in HTML4, but scrolling and frameborder are transitioned to HTML5
Testing Instructions
You can use Joomla's current settings for width & height, but you need to modify your settings for borders and scrollbars.
Expected result
To work flawlessly.
Documentation Changes Required
Need to modify 6 files to work without any problems or hiccups:
-
modules/mod_wrapper/mod_wrapper.xml
-
modules/mod_wrapper/mod_wrapper.php
-
modules/mod_wrapper/Helper/WrapperHelper.php
-
modules/mod_wrapper/tmpl/default.php
-
components/com_wrapper/tmpl/wrapper/default.xml
-
components/com_wrapper/tmpl/wrapper/default.php
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_wrapper Modules |
| Labels |
Added:
?
|
||
For future reference - never use w3schools as a source - it is rarely complete or accurate. Much better to use https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe
Sorry, but I prefer using https://www.w3schools.com/html/html_iframe.asp & https://www.w3schools.com/tags/tag_iframe.asp
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-09 18:54:31 |
| Closed_By | ⇒ | BaleshSrle |
For future reference - never use w3schools as a source - it is rarely complete or accurate. Much better to use https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe