[#25116] - [4.0] Inline Messages/Alerts
- Fixed in Code Base
- 13 Jun 2019
- Medium
- Build: 4.0-dev
- # 25116
- Diff
- brianteeman:inline_messages
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
In J4 we currently have two types of alert. One uses a custom element and is a "popup" the other is a regular div or "inline". This PR is to improve the accessibility of the inline messages/alerts.
Currently we only convey the importance of the text by use of color which conveys no meaning for a color blind user. Accessibility golden rule is to never rely on just one visual indicator so this PR adds an icon.
Secondly we need to convey the importance of the text to screen readers. The text alone is not always sufficient to do that so this PR adds a sr-only text
This is based on the discussions joomla-projects/custom-elements#99
Note: The icon could have been added just with css but as we were adding the sr-only text I couldnt see any advantage
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_categories com_config com_contact com_content com_csp com_fields com_finder com_installer com_joomlaupdate |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
It seems com_tags was forgotten?
And com_newsfeeds?
@richard67 That looks like an issue with com_patchtester not updating all the files - probably because there are so many. If you check the files changed you can see that neither of these have been forgotten.
@brianteeman I think you are right, patchtester was a bit slow with this PR. Is of course your fault, you updated too many files
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25116.
No his comment is wrong
On Sun, 9 Jun 2019 at 12:37, Richard Fath notifications@github.com wrote:
I have tested this item
✅ successfully on 72ed01b
72ed01bThis comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/tracker/joomla-cms/25116.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/25116?email_source=notifications&email_token=AAJ4P4KVUCDEOMDLTBQ3YTDPZTTOJA5CNFSM4HS2LXO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIIN4I#issuecomment-500205297,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ4P4NHTPCMJZHFD7AJXITPZTTOJANCNFSM4HS2LXOQ
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
@brianteeman I did not mean that he is right, I only meant that what he says he would say here, too. From my point of view, replacing fontawesome with inline svg or whatever else is subject of another, future PR, so I agree with you.
@richard67 the decision was made that fontawesome would be supported in the admin iirc - @wilsonge can confirm
@brianteeman I know, and saw meanwhile that this here is admin only, while other one was site, too. So I tested this here with success. It has 2 good tests now and could be set RTC.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-13 06:53:33 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
Removed: ? |
||
Thank you
Thanks
I have tested this item✅ successfully on 72ed01b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25116.