? ? Pending

User tests: Successful: Unsuccessful:

avatar webgras
webgras
3 Jun 2019

Pull Request for Issue #25099 .

Summary of Changes

Change language code for verification error message.

Testing Instructions

Setup global user options for "Allow User Registration" - Yes
"New User Account Activation" - "Self"
Register a new user in the frontend.
Now you have two options:

  1. Go back to Administrator and activate the user manually. Then go back to the email and click the confirmation link in the email.
    --> error message "verification code not found".
  2. don't activate the user manually, but click the activation email one time. --> user is activated
    Now, if you click the activation link again, the error is also shown.

Expected result

User get confused, give more information why the token is not found.

Actual result

New error message: Verification code not found. Check if your account is already activated and try to log in. Check also if the token is copied correctly to the browser address bar.

Documentation Changes Required

avatar webgras webgras - open - 3 Jun 2019
avatar webgras webgras - change - 3 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2019
Category Language & Strings
avatar brianteeman
brianteeman - comment - 3 Jun 2019

Personally speaking I don't see this as a general improvement - especially the last sentence which is meaningless on a mobile device.

For me this is the sort of the thing that should be left to the site owner to modify as an override

avatar webgras
webgras - comment - 3 Jun 2019

@brianteeman hm, yes, probably. However, it is not so easy to find out why you get this error message. I mean, the administrator might know that the account would be already activated. But the enduser in the frontend gets an error that they could actually overcome, if they would go and try logging in. But they have no idea they could do that.

I think in quite some projects it would help people to find the solution faster. My client had quite some discouraged users.

I was not sure about the second part - yes, for mobile device that does not make sense. So, maybe just remove that part.

I am okay if it does not get merge - i wanted to help UX. I am okay in my projects with this error to solve.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2019

@webgras Can you delete the last Sentence "Check also if the token is copied correctly to the browser address bar."? The "Check if your account is already activated and try to log in." is helpful.

@brianteeman comment?

avatar brianteeman
brianteeman - comment - 20 Jul 2019

The other solution would be to check if the account has already been verified and only then to display that specific error message

avatar ChristineWk
ChristineWk - comment - 7 Aug 2019

I have tested this item successfully on 852855d

Hi Sigrid,

after Patch, got following response:
403 Verification code not found. Check if your account is already activated and try to log in. Check also if the token is copied correctly to the browser address bar.

But this: "Check also if the token is copied correctly to the browser address bar." is confusing :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25107.
avatar ChristineWk
ChristineWk - comment - 7 Aug 2019

I have tested this item successfully on 852855d

Hi Sigrid,

after Patch, got following response:
403 Verification code not found. Check if your account is already activated and try to log in. Check also if the token is copied correctly to the browser address bar.

But this: "Check also if the token is copied correctly to the browser address bar." is confusing :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25107.
avatar ChristineWk ChristineWk - test_item - 7 Aug 2019 - Tested successfully
avatar anibalsanchez anibalsanchez - test_item - 27 Oct 2019 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 27 Oct 2019

I have tested this item successfully on 852855d

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25107.

avatar SharkyKZ SharkyKZ - change - 27 Oct 2019
Status Pending Ready to Commit
Labels Added: ? ?
avatar SharkyKZ
SharkyKZ - comment - 27 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25107.

avatar SharkyKZ SharkyKZ - change - 27 Oct 2019
Status Ready to Commit Pending
avatar SharkyKZ SharkyKZ - change - 27 Oct 2019
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 27 Oct 2019

RTC

avatar brianteeman
brianteeman - comment - 27 Oct 2019

@SharkyKZ just because something has 2 tests doesn't mean it should automatically be RTC

This relates to an english language string. No native english speaker has approved/tested this. One of the testers still commented that they didnt understand the new message

avatar SharkyKZ
SharkyKZ - comment - 27 Oct 2019

@brianteeman Shouldn't a maintainer decide what to do next?

avatar infograf768
infograf768 - comment - 27 Oct 2019

Imho, we could do without the last sentence indeed.

avatar SharkyKZ SharkyKZ - change - 27 Oct 2019
Status Ready to Commit Pending
avatar SharkyKZ
SharkyKZ - comment - 27 Oct 2019

Status set back to Pending. Bot keeps adding PR-4.0-dev label ?

avatar infograf768
infograf768 - comment - 28 Oct 2019

@webgras
Please modify this PR by taking off the last sentence.

avatar webgras webgras - change - 28 Oct 2019
Labels Added: ?
Removed: ?
avatar webgras
webgras - comment - 28 Oct 2019

ah, sorry, wrong button. I will change the language string and then commit again.

avatar HLeithner
HLeithner - comment - 28 Oct 2019

The other solution would be to check if the account has already been verified and only then to display that specific error message

@brianteeman Without looking at the code I think we don't want to expose if the account exists or not. I know maybe makes not much sense to hide it, at least for sites with public registrations.

Anyway do you have anything against the wording?

avatar brianteeman
brianteeman - comment - 28 Oct 2019

@HLeithner possibly correct - it was just a suggestion because I don't like having a single message for multiple "errors"

avatar HLeithner
HLeithner - comment - 28 Oct 2019

ok thanks for then I merge this and if someone came up with a better solution we can talk about this again.

avatar HLeithner HLeithner - change - 28 Oct 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-28 10:37:24
Closed_By HLeithner
avatar HLeithner HLeithner - close - 28 Oct 2019
avatar HLeithner HLeithner - merge - 28 Oct 2019
avatar HLeithner
HLeithner - comment - 28 Oct 2019

thanks @webgras for this patch

Add a Comment

Login with GitHub to post a comment