User tests: Successful: Unsuccessful:
Pull Request for Issue #25099 .
Change language code for verification error message.
Setup global user options for "Allow User Registration" - Yes
"New User Account Activation" - "Self"
Register a new user in the frontend.
Now you have two options:
User get confused, give more information why the token is not found.
New error message: Verification code not found. Check if your account is already activated and try to log in. Check also if the token is copied correctly to the browser address bar.
Status | New | ⇒ | Pending |
Category | ⇒ | Language & Strings |
@brianteeman hm, yes, probably. However, it is not so easy to find out why you get this error message. I mean, the administrator might know that the account would be already activated. But the enduser in the frontend gets an error that they could actually overcome, if they would go and try logging in. But they have no idea they could do that.
I think in quite some projects it would help people to find the solution faster. My client had quite some discouraged users.
I was not sure about the second part - yes, for mobile device that does not make sense. So, maybe just remove that part.
I am okay if it does not get merge - i wanted to help UX. I am okay in my projects with this error to solve.
@webgras Can you delete the last Sentence "Check also if the token is copied correctly to the browser address bar."? The "Check if your account is already activated and try to log in." is helpful.
@brianteeman comment?
The other solution would be to check if the account has already been verified and only then to display that specific error message
I have tested this item
Hi Sigrid,
after Patch, got following response:
403 Verification code not found. Check if your account is already activated and try to log in. Check also if the token is copied correctly to the browser address bar.
But this: "Check also if the token is copied correctly to the browser address bar." is confusing :-)
I have tested this item
Hi Sigrid,
after Patch, got following response:
403 Verification code not found. Check if your account is already activated and try to log in. Check also if the token is copied correctly to the browser address bar.
But this: "Check also if the token is copied correctly to the browser address bar." is confusing :-)
I have tested this item
Test OK
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
?
|
RTC
Status | Ready to Commit | ⇒ | Pending |
Status | Pending | ⇒ | Ready to Commit |
RTC
@brianteeman Shouldn't a maintainer decide what to do next?
Imho, we could do without the last sentence indeed.
Status | Ready to Commit | ⇒ | Pending |
Status set back to Pending. Bot keeps adding PR-4.0-dev label
Labels |
Added:
?
Removed: ? |
ah, sorry, wrong button. I will change the language string and then commit again.
The other solution would be to check if the account has already been verified and only then to display that specific error message
@brianteeman Without looking at the code I think we don't want to expose if the account exists or not. I know maybe makes not much sense to hide it, at least for sites with public registrations.
Anyway do you have anything against the wording?
@HLeithner possibly correct - it was just a suggestion because I don't like having a single message for multiple "errors"
ok thanks for then I merge this and if someone came up with a better solution we can talk about this again.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-28 10:37:24 |
Closed_By | ⇒ | HLeithner |
Personally speaking I don't see this as a general improvement - especially the last sentence which is meaningless on a mobile device.
For me this is the sort of the thing that should be left to the site owner to modify as an override