[#25105] - 4.0 packages
- Closed
- 1 Aug 2020
- Medium
- Build: 4.0-dev
- # 25105
- Diff
- BrainforgeUK:4.0-packages
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #17585 .
Summary of Changes
Added -- Select Package -- list to filter in extension manager, module manager and plugin manager.
Testing Instructions
Goto .../administrator/index.php?option=com_installer&view=manage
Click on filter options
Expected result
Select a package and only extensions within the package (plus the package itself) will be displayed.
Similar result with module and plugin managers.
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_modules com_plugins Language & Strings |
| Labels |
Added:
?
?
|
||
I can see the use in the extension manager but what is the use case for modules and plugins especially as we don't display the package information there
The original issue mentioned having links to plugin edit in manager listing. Not implemented for 4.0 (but might still be a good idea). Being able to filter plugins and modules by package useful when all one is interested in are package related extensions - no other clutter!
@BrainforgeUK Can it be that file "administrator/language/en-GB/en-GB.com_installer.ini" in your PR is based on an outdated version? When checking the differences in the modified files of your PR, I see for this file more changes than those related to what you PR does, and some of the changes make things wrong, e.g. "a update" instead of "an update", or "upload extensions into the installer" instead of "upload extensions with the installer.".
Being able to filter plugins and modules by package useful when all one is interested in are package related extensions - no other clutter!
As there is no way for me to know if a plugin or modules belongs to a package on that screen I dont see how I would even know what to filter by.
This really sounds like a way of solving a problem with an extension by modifying the core to me.
I have tested this item
after applying the patch, i got a broken site.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25105.
@Schmidie64 Sure, because PR is not really ready for test. Due to changes in the 4.0-dev branch which have happened meanwhile, this patch needs to be updated, and conflicts need to be resolved. When a patch shows it has conflicts at the bottom of the GitHub page, it makes no sense to test it because it will very likely fail. So I recommend you change back your tes result to "I have not tested this item" in the issue tracker.
@BrainforgeUK Could you update your PR to latest 4.0-dev and solve the conflicts?
Made changes and commited and pushed to github.
https://github.com/BrainforgeUK/joomla-cms/tree/4.0-packages
Cannot see them in the pull-request.
@BrainforgeUK I think your last push did come through just not so fast as I can see the commits above your message. Do you want to fix the conflicts and pick this up or should the pull request be deleted?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-01 18:07:59 |
| Closed_By | ⇒ | BrainforgeUK | |
| Labels |
Added:
Conflicting Files
|
||
I can see the use in the extension manager but what is the use case for modules and plugins especially as we don't display the package information there