J3 Issue ?
avatar webgras
webgras
3 Jun 2019

What needs to be fixed

Improve the language string COM_USERS_ACTIVATION_TOKEN_NOT_FOUND
old: Verification code not found.
new: Verification code not found. Check if your account is already activated and try to log in.

Why this should be fixed

If a user registers at the website and gets the confirmation email to activate the account, and clicks the confirmation link with the authentication token more then one time, then the error message shows only "verification code not found".
But maybe the account is already activated

  • by the user (unintended double click, trying to activate for the second time after a few days, ...)
  • by an administrator
  • by a virus scanner, that followed the link in the email.

However, the user could already login, but does not know.

How would you fix it

Add information in the language string

Side Effects expected

Probably none, or maybe spammers who will get more information than necessary.

avatar webgras webgras - open - 3 Jun 2019
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Jun 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Jun 2019

Guess its for J3.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jun 2019
Labels Added: J3 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 3 Jun 2019
avatar webgras
webgras - comment - 3 Jun 2019

yes, sorry, forgot to mention.

avatar Quy
Quy - comment - 3 Jun 2019

Please submit your PR to Joomla repo.

avatar webgras
webgras - comment - 3 Jun 2019

Please submit your PR to Joomla repo.

yes, I will do that.

However, somebody suggested in a glip channel, that in case the activation token is - for example - not copied correctly or with a line break within the email, then the token will not be found. Then the error message is correct. So probably, we should also give information about that.

Shall we add some more information like that?
"Verification code not found. <br>Check if your account is already activated and try to log in. Check also if the token is copied correctly to the browser address bar."

avatar Quy
Quy - comment - 3 Jun 2019

Go for it. Others can comment once there is a PR to test.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jun 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-06-03 14:37:01
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - close - 3 Jun 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Jun 2019

Closed as having Pull Request #25107

Add a Comment

Login with GitHub to post a comment