? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
3 Jun 2019

Pull Request for Issue #25088 .

Summary of Changes

In #22166 we solved com_associations side by side "Bug1" by adding id to $hiddenFields in layouts/joomla/edit/global.php.
This only concerned articles when Show Publishing Options was set to Hide in Articles Options.

As found out in #25088, this creates a duplicate ID.
Example: see source in administrator/index.php?option=com_tags&view=tag&layout=edit
To solve the issue, this PR adds the $hidden_fields directly in the article edit tmpl and takes it off from global.php.

Testing Instructions

Patch a clean install. (This can be done using Patchtester on a nighlty build)
Create a multilingual site by installing 2 languages and using the Multilingual Sample Data module in CPanel.
Set Show Publishing Options to Hide in Articles Options.
Load com_associations and set the filters to Articles and one of the content languages.
Click on the title of one of the articles to make sure the side by side will not loop.
Load administrator/index.php?option=com_tags&view=tag&layout=edit and verify that we have only one jform_id

After patch

All still works fine for side by side in com_associations.
No more duplicate ID

avatar infograf768 infograf768 - open - 3 Jun 2019
avatar infograf768 infograf768 - change - 3 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2019
Category Administration com_content Layout
avatar infograf768 infograf768 - change - 3 Jun 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 3 Jun 2019

After applying the PR and going to the article edit form

image

avatar infograf768
infograf768 - comment - 3 Jun 2019

You are right. Looking into this now.

avatar infograf768
infograf768 - comment - 3 Jun 2019

@brianteeman
Can you test again? I have put the echo in a hidden <div>
Did not find another way.

avatar brianteeman
brianteeman - comment - 3 Jun 2019

Sorry but this is not correct as there is still the ID in the publishing tab so if that is enabled you still get the duplicate id

avatar brianteeman
brianteeman - comment - 3 Jun 2019

I have tested this item ? unsuccessfully on 0ec4a77


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25096.

avatar brianteeman
brianteeman - comment - 3 Jun 2019

I have tested this item ? unsuccessfully on 0ec4a77


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25096.

avatar brianteeman brianteeman - test_item - 3 Jun 2019 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 3 Jun 2019

this is not correct as there is still the ID in the publishing tab so if that is enabled you still get the duplicate id

Correct. Added now conditional to echo the hiddenfield depending on Publishing Options.

Please test again.

avatar brianteeman
brianteeman - comment - 3 Jun 2019

I have tested this item successfully on 5c85a91

I wont pretend to understand it but it works


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25096.

avatar brianteeman brianteeman - test_item - 3 Jun 2019 - Tested successfully
avatar Quy Quy - test_item - 28 Jun 2019 - Tested successfully
avatar Quy
Quy - comment - 28 Jun 2019

I have tested this item successfully on b93ba3f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25096.

avatar Quy Quy - change - 28 Jun 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 28 Jun 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25096.

avatar infograf768 infograf768 - change - 28 Jun 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 23 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-23 18:29:53
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Jul 2019
avatar wilsonge wilsonge - merge - 23 Jul 2019
avatar wilsonge
wilsonge - comment - 23 Jul 2019

Thanks!

Add a Comment

Login with GitHub to post a comment