User tests: Successful: Unsuccessful:
Pull Request for Issue #25088 .
In #22166 we solved com_associations side by side "Bug1" by adding id
to $hiddenFields
in layouts/joomla/edit/global.php
.
This only concerned articles when Show Publishing Options
was set to Hide
in Articles Options.
As found out in #25088, this creates a duplicate ID.
Example: see source in administrator/index.php?option=com_tags&view=tag&layout=edit
To solve the issue, this PR adds the $hidden_fields
directly in the article edit tmpl and takes it off from global.php.
Patch a clean install. (This can be done using Patchtester on a nighlty build)
Create a multilingual site by installing 2 languages and using the Multilingual Sample Data module in CPanel.
Set Show Publishing Options
to Hide
in Articles Options.
Load com_associations and set the filters to Articles and one of the content languages.
Click on the title of one of the articles to make sure the side by side will not loop.
Load administrator/index.php?option=com_tags&view=tag&layout=edit
and verify that we have only one jform_id
All still works fine for side by side in com_associations.
No more duplicate ID
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content Layout |
Labels |
Added:
?
|
You are right. Looking into this now.
@brianteeman
Can you test again? I have put the echo in a hidden <div>
Did not find another way.
Sorry but this is not correct as there is still the ID in the publishing tab so if that is enabled you still get the duplicate id
I have tested this item
I have tested this item
this is not correct as there is still the ID in the publishing tab so if that is enabled you still get the duplicate id
Correct. Added now conditional to echo the hiddenfield depending on Publishing Options.
Please test again.
I have tested this item
I wont pretend to understand it but it works
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-23 18:29:53 |
Closed_By | ⇒ | wilsonge |
Thanks!
After applying the PR and going to the article edit form