Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25090] - [4.0] [com_users] convert to prepared statement

? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
3 Jun 2019

Summary of Changes

use prepared statement for SQL

Testing Instructions

test com_users

Expected result

should work as before

Actual result

N/A

avatar alikon alikon - open - 3 Jun 2019
avatar alikon alikon - change - 3 Jun 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2019
Category ⇒ Front End com_users
avatar alikon alikon - change - 3 Jun 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jun 2019
Title
…
[4.0][com_users][wip] convert to prepared statement
[4.0] [com_users] [wip] convert to prepared statement
avatar franz-wohlkoenig franz-wohlkoenig - edited - 3 Jun 2019
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2019
Category Front End com_users ⇒ Administration com_users Front End
avatar alikon alikon - change - 8 Jun 2019
Title
…
[4.0] [com_users] [wip] convert to prepared statement
[4.0] [com_users] convert to prepared statement
avatar alikon alikon - edited - 8 Jun 2019
avatar Quy
Quy - comment - 5 Oct 2019

Under Permissions, searches are OR and not AND.

Install Blog Sample Data.
Edit admin account.
Click Permissions icon.
Search release.
Click Filter Options button.
Select Modules.
One item found.
Apply PR.
Edit Permissions again.
Many items found.

avatar alikon
alikon - comment - 6 Oct 2019

can you re-check ... should be fixed now

avatar joeykrop joeykrop - test_item - 19 Oct 2019 - Tested successfully
avatar joeykrop
joeykrop - comment - 19 Oct 2019

I have tested this item ✅ successfully on 2f6ed1d

Tested the following problem:
Under Permissions, searches are OR and not AND.

This problem seems to be fixed.

Also poked around some more in com_users. No issues found.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25090.

avatar chmst chmst - test_item - 19 Oct 2019 - Tested successfully
avatar chmst
chmst - comment - 19 Oct 2019

I have tested this item ✅ successfully on 2f6ed1d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25090.

avatar Quy Quy - change - 19 Oct 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25090.

avatar wilsonge wilsonge - change - 19 Oct 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Oct 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-19 14:24:13
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 19 Oct 2019
avatar wilsonge wilsonge - merge - 19 Oct 2019
avatar wilsonge
wilsonge - comment - 19 Oct 2019

Thanks

avatar wilsonge
wilsonge - comment - 19 Oct 2019

@alikon can you check this on postgres for me please - specifically creating a user. System tests are failing and I'm wondering if it's related to this patch (i might be wrong)

Add a Comment

Login with GitHub to post a comment