[#2509] - Fix of copy template case where template name is same as a name in the path to the joomla instance
- Closed
- 6 Feb 2015
- Medium
- Build: master
- # 2509
- Diff
- wonderslug:copy_template_fix
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
In the case where the path to the Joomla instance is the same as the template name, the TemplatesModelTemplate->fixTemplateName function replaces the old templates name in every location along the path not just in the ini file names.
This is just a simple fix to keep the directory path separate and only do the replace in the file name itself.
| Status | New | ⇒ | Pending |
| Build | ⇒ | . |
| Category | ⇒ | Template |
A joomlacode item is no longer required
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2509.
| Labels |
Added:
?
|
||
@wonderslug Thanks for submitting! Please close this pull requests and submit your code towards the staging branch instead. Thanks!
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-06 15:04:31 |
| Closed_By | ⇒ | zero-24 |
Closing here as there was no response since the last comment by @nicksavov Please open a new PR against the staging branche.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2509.
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/2509
| Closed_Date | 2015-02-06 15:04:31 | ⇒ | 2015-02-06 15:04:30 |
Thanks for your contribution. Can you please open a related item on the tracker http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103 so that it can be tested etc