[#25086] - [4.0] Removing base tag from frontend
- Closed
- 2 Jun 2019
- Medium
- Build: 4.0-dev
- # 25086
- Diff
- Hackwar:patch-6
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9010.
This is a new version of #25077, since the CI system somehow fails with that earlier PR.
Summary of Changes
This removes the base tag from the frontend. The idea of the base tag is to define a base for relative URLs. Consider you have the site http://www.example.com/this/is/index.php/with/more/content and all requests should go to the folder http://www.example.com/this/is/, you would set the base tag to exactly that URL. However, we are setting that base tag always to the current URL, which simply is wrong. Even worse, we aren't doing it correctly, because we are forgetting the query part. So we are not setting it to a special path, but are just using the current URL. Now guess what the default value is, when that base tag is NOT set at all. The answer is not "42", but: The current URL.
A quick check shows that neither Wordpress nor Drupal or Typo3 seem to have a base tag in their default output. We are just oh-so-special... Sorry...
Testing Instructions
Apply this change and then check if everything on your site still works as expected.
This would be a fix for an issue that is over 3 years old and that has been discussed several times in the Joomla project... Would be nice to finally solve that.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
Please wait a moment. I first want to make sure that drone works now.
rdeutz
- | Labels |
Added:
?
|
||
The issue has been found and the original PR can be used. Closing this one.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-02 18:47:53 |
| Closed_By | ⇒ | Hackwar |
close #25077?