[#25065] - Decode SEF with multiple tag ids
- Fixed in Code Base
- 31 Jul 2019
- Medium
- Build: staging
- # 25065
- Diff
- Waldbaer88:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
PR for Issue #24980
Summary of Changes
A link including an array of tag ids like this:
index.php?option=com_tags&view=tag&id[0]=1&id[1]=2
will be like the following after SEF-conversion:
/component/tags/tag/1,2
Until now, any id after the first of the SEF-link will be truncated by the line I changed - my fix will explode it again to include all of them.
Testing Instructions
Part I - See the problem
- In a layout override, add a link like this one (make sure the ids are real tag ids on your site):
<a href="index.php?option=com_tags&view=tag&id[0]=1&id[1]=2">my test link</a> - Make sure SEF is turned off in the global settings. Your link should work as expected and open a site showing both tags.
- Turn on SEF in the global configuration. Reload your test-override. Your link URL will be converted. Test the link.
Expected result
Same as with SEF turned off: A site showing all submitted tags.
Actual result
You will get a site showing only the first tag in the URL but ignore the other one.
Testing Instructions
Part II - Fix the problem
- Apply this PR.
- Test your link again - it should now work and show all tags as expected, no matter if SEF is turned on or off.
Documentation Changes Required
None, no feature changes.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have tested this item
Works as described. Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25065.
I have tested this item
Works as described. Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25065.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25065.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25065.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25065.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25065.
| Labels |
Added:
?
|
||
thx
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-31 09:17:35 |
| Closed_By | ⇒ | HLeithner |
I just checked that listing multiple tags (2, 3, ... pcs) concatenates tags in the title without separator. The result for four multi-word tags may be "tag 1 tag 2 tag named something this is a tag". It makes easier to understand the results, if a separator is used: vertical line | or logical text "OR": "Content for: tag 1 OR tag 2 OR tag named something OR this is a tag". This should go to a new issue to describe and to be solved, right?
Yes but for j4
@kofaysi can you please test this PR (as its about Tags)?