Hope it's ok now @shanginn

It's still running an empty query.

I found another problem, if $db->setQuery($query) is not in the try catch construct and the sql query is broken (for example $value is 0 which is not possible any longer) then joomla raise an exception on setQuery because we do a Driver->prepareStatement() in this function.

This is already true for the current implementation...

Also I'm not sure how the query with the HAVING clause could fail and the original query would work.

if you have a query

select id as value, title as text from #__content

then the having variant will always work

select id as value, title as text from #__content HAVING VALUE IN ('1');

if the query fails because no value column exists it will also fail without the having clause because we expect a value column...

What do I miss?

We don't know what kind of query is entered so adding anything could break it. For example if entered query ends in ; the code already fails as it results in this:

select id as value, title as text from #__content; HAVING VALUE IN ('1');

Another case, the query could already have a HAVING clause.

We could avoid the first scenario by loading SQL into the query object and using the API to build having clause instead of directly manipulating SQL.

We could avoid the first scenario by loading SQL into the query object and using the API to build having clause instead of directly manipulating SQL.

Jquery doesn't split the query into parts.

So we should keep it this way until someone builds the ultimate query builder ;)

Hm, you're right. Although we could still use query methods for HAVING clause. But it's fine either way. Just lowercase and quote value please because it's a column name.

I have tested this item ✅ successfully on a952aed

I have tested this item ✅ successfully on a952aed

RTC