Currently (with or without patch) the plugin doesn't return any articles due to invalid workflow query. Do you want to add a fix in here? Or should we wait until this is merged first?

@SharkyKZ Can you point me to the workflow query problem?

Here are related PRs #24785, #24494.

I it's not a problem of the PR I would merge it WF needs a major update anyway.

Fix conflict please.

PHP Notice:  Undefined index: :publishup in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 412
PHP Notice:  Undefined index: :publishup in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 413
PHP Warning:  mysqli_stmt::bind_param(): Number of variables doesn't match number of parameters in prepared statement in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 430

To reproduce:

• install Testing Sample Data
• on front end, click Article Category List
• click Beginners

PHP Notice:  Undefined index: :publishup in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 412
PHP Notice:  Undefined index: :publishup in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 413
PHP Warning:  mysqli_stmt::bind_param(): Number of variables doesn't match number of parameters in prepared statement in \libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php on line 430

To reproduce:

• install Testing Sample Data
• on front end, click Article Category List
• click Beginners

can you post a stack trace ?

1 | () | JROOT\libraries\vendor\joomla\database\src\Mysqli\MysqliStatement.php:432
-- | -- | --
2 | Joomla\Database\Mysqli\MysqliStatement->execute() | JROOT\libraries\vendor\joomla\database\src\DatabaseDriver.php:673
3 | Joomla\Database\DatabaseDriver->execute() | JROOT\libraries\vendor\joomla\database\src\DatabaseDriver.php:1336
4 | Joomla\Database\DatabaseDriver->loadObjectList() | JROOT\plugins\content\pagenavigation\pagenavigation.php:208
5 | PlgContentPagenavigation->onContentBeforeDisplay() | JROOT\libraries\src\Plugin\CMSPlugin.php:285
6 | Joomla\CMS\Plugin\CMSPlugin->Joomla\CMS\Plugin\{closure}() | JROOT\libraries\vendor\joomla\event\src\Dispatcher.php:495
7 | Joomla\Event\Dispatcher->dispatch() | JROOT\libraries\src\Application\EventAware.php:111
8 | Joomla\CMS\Application\WebApplication->triggerEvent() | JROOT\components\com_content\View\Article\HtmlView.php:249
9 | Joomla\Component\Content\Site\View\Article\HtmlView->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:690
10 | Joomla\CMS\MVC\Controller\BaseController->display() | JROOT\components\com_content\Controller\DisplayController.php:127
11 | Joomla\Component\Content\Site\Controller\DisplayController->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:728
12 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:146
13 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT\components\com_content\Dispatcher\Dispatcher.php:55
14 | Joomla\Component\Content\Site\Dispatcher\Dispatcher->dispatch() | JROOT\libraries\src\Component\ComponentHelper.php:383
15 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT\libraries\src\Application\SiteApplication.php:205
16 | Joomla\CMS\Application\SiteApplication->dispatch() | JROOT\libraries\src\Application\SiteApplication.php:244
17 | Joomla\CMS\Application\SiteApplication->doExecute() | JROOT\libraries\src\Application\CMSApplication.php:241
18 | Joomla\CMS\Application\CMSApplication->execute() | JROOT\includes\app.php:63
19 | require_once() | JROOT\index.php:36

Thx, while checking the code I don't find a reason for this. I have to investigate further...

No prepared statement to bind to?

$query->bind(':publishup', $nullDate);

I have tested this item ✅ successfully on 62ff557

Doesn't work, just like before.

@SharkyKZ Your comment contradicts your successful test. Should it be marked unsuccessful?

It's fine. Just that existing issue (#25051 (comment)) hasn't been fixed in this PR.

Conflicts please

@wilsonge conflicts solved.

I have tested this item ? unsuccessfully on fa63af1

Patch contains SQL error:

 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'IS NULL OR `publish_down` >= ?) ORDER BY `a`.`ordering`' at line 5 

Call stack
# 	Function 	Location
1 	() 	JROOT/libraries/vendor/joomla/database/src/Mysqli/MysqliStatement.php:149
2 	Joomla\Database\Mysqli\MysqliStatement->__construct() 	JROOT/libraries/vendor/joomla/database/src/Mysqli/MysqliDriver.php:1032
3 	Joomla\Database\Mysqli\MysqliDriver->prepareStatement() 	JROOT/libraries/vendor/joomla/database/src/DatabaseDriver.php:1862
4 	Joomla\Database\DatabaseDriver->setQuery() 	JROOT/plugins/content/pagenavigation/pagenavigation.php:203
5 	PlgContentPagenavigation->onContentBeforeDisplay() 	JROOT/libraries/src/Plugin/CMSPlugin.php:285
6 	Joomla\CMS\Plugin\CMSPlugin->Joomla\CMS\Plugin\{closure}() 	JROOT/libraries/vendor/joomla/event/src/Dispatcher.php:495
7 	Joomla\Event\Dispatcher->dispatch() 	JROOT/libraries/src/Application/EventAware.php:111
8 	Joomla\CMS\Application\WebApplication->triggerEvent() 	JROOT/components/com_content/View/Article/HtmlView.php:249
9 	Joomla\Component\Content\Site\View\Article\HtmlView->display() 	JROOT/libraries/src/MVC/Controller/BaseController.php:690
10 	Joomla\CMS\MVC\Controller\BaseController->display() 	JROOT/components/com_content/Controller/DisplayController.php:127
11 	Joomla\Component\Content\Site\Controller\DisplayController->display() 	JROOT/libraries/src/MVC/Controller/BaseController.php:728
12 	Joomla\CMS\MVC\Controller\BaseController->execute() 	JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:146
13 	Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() 	JROOT/components/com_content/Dispatcher/Dispatcher.php:55
14 	Joomla\Component\Content\Site\Dispatcher\Dispatcher->dispatch() 	JROOT/libraries/src/Component/ComponentHelper.php:383
15 	Joomla\CMS\Component\ComponentHelper::renderComponent() 	JROOT/libraries/src/Application/SiteApplication.php:205
16 	Joomla\CMS\Application\SiteApplication->dispatch() 	JROOT/libraries/src/Application/SiteApplication.php:244
17 	Joomla\CMS\Application\SiteApplication->doExecute() 	JROOT/libraries/src/Application/CMSApplication.php:241
18 	Joomla\CMS\Application\CMSApplication->execute() 	JROOT/includes/app.php:63
19 	require_once() 	JROOT/index.php:36 <hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/25051">issues.joomla.org/tracker/joomla-cms/25051</a>.</sub>

thx @JazParkyn is fixed now thx to @Quy

I have tested this item ? unsuccessfully on ada289b

"Category List" works, "Category Blog" doesn´t. This problem exists also without this patch.

I tested with postgresql.

Please fix conflicts.

OK let's get some tests here - this is the last PR in the prepared statements project - would be nice to get that finally shut down

See #27587 which prevents testing.

That issue is unrelated to this plugin I’ve clarified there

Please fix conflicts.

Should be fixed

@HLeithner can you spend some time fixing the issue raised here please

@HLeithner bump again

Should work again now...

I have tested this item ✅ successfully on c8f3afc

I have tested this item ✅ successfully on c8f3afc

RTC

Thanks!