Feeling Lucky
?
?
[#25046] - [4.0] Add prepared statements for plg_actionlog_joomla
- Fixed in Code Base
- 8 Jun 2019
- Medium
- Build: 4.0-dev
- # 25046
- Diff
- HLeithner:prepared-plg-actionlog-joomla
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Updated SQL queries to prepared statements and made some cleanups around the queries.
Testing Instructions
Use the plugin in all ways you can think of.
- Activate the privacy extension with actionlog
- change the state of a article
- You should see the change in the actionlog as without the PR
Expected result
Nothing changed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
franz-wohlkoenig
- | Title |
|
||||||
alikon
- comment
- 5 Jun 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25046.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 5 Jun 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25046.
roland-d
- comment
- 7 Jun 2019
@HLeithner the code works but is it correct the query is:
`SELECT `title`,`id`
FROM `jos_content`
WHERE `id` IN (:preparedArray1)
The :preparedArray1 looks odd.
HLeithner
- comment
- 7 Jun 2019
:preparedArray1 is defined in the database driver. I selected this name because I hope nobody else will use it by accident.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-08 18:39:42 |
| Closed_By | ⇒ | SniperSister | |
| Labels |
Added:
?
|
||
SniperSister
- comment
- 8 Jun 2019
Merged, thanks!
I have tested this item✅ successfully on 198a4e4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25046.