Joomla! Issue Tracker | Joomla! CMS #25037 - Tinymce doesn't need to remove the images basepath

? ?

Fixed in Code Base
5 Jun 2019
Medium
Build: staging
# 25037
Diff
HLeithner:tinymce-dnd-path

Success

Success Hound No violations found. Woof! Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/drone/pr Build is passing Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

HLeithner
29 May 2019

Pull Request for Issue #25015 .

Summary of Changes

Removed the deletion of the image base path from the upload path.

Testing Instructions

c/p from #25015 (comment)

Create a sub-directory of "images" under the main images directory.
Create a sub-directory of "testing123" under that directory.

Update the plugin: Editor - TinyMCE
Make sure you are editing tab "Set 0" so Administrator is showing in the groups that use this profile.
Under the "Images Directory" setting, select "images/testing123" (save & close)

please try all variants

the actual path on the server is "images/images/testing123"
Go under content, and articles and either create a new or edit an existing.

Drag and Drop an image into the content window.

Also change the image and file path in com_media options and try it with different pathes

Expected result

You should not receive an error and see the image.

Actual result

You should receive an error the file can not be uploaded, showing the filename as undefined.

0c74692 29 May 2019

Tinymce doesn't need remove the images basepath

HLeithner - open - 29 May 2019

HLeithner - change - 29 May 2019

Status

New

⇒

Pending

joomla-cms-bot - change - 29 May 2019

Category

⇒

Front End Plugins

e2becdf 29 May 2019

Merge branch 'staging' into tinymce-dnd-path

infograf768 - change - 29 May 2019

Labels

Added: ?

GCLW - comment - 29 May 2019

Tested with above listed parameters and this update worked.
Additional tests:

Set TinyMCE image dir to images (images/images) - Drag and Drop worked.
Set TinyMCE to just a sub-directory under the main images directory - Drag and Drop worked.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25037.}

GCLW - comment - 29 May 2019

Tested with above listed parameters and this update worked.
Additional tests:

Set TinyMCE image dir to images (images/images) - Drag and Drop worked.
Set TinyMCE to just a sub-directory under the main images directory - Drag and Drop worked.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25037.}

GCLW - test_item - 29 May 2019 - Tested successfully

GCLW - comment - 29 May 2019

I have tested this item ✅ successfully on e2becdf

Tested with above listed parameters and this update worked.
Additional tests:

Set TinyMCE image dir to images (images/images) - Drag and Drop worked.
Set TinyMCE to just a sub-directory under the main images directory - Drag and Drop worked.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25037.}

GCLW - comment - 29 May 2019

I have tested this item ✅ successfully on e2becdf

Tested with above listed parameters and this update worked.
Additional tests:

Set TinyMCE image dir to images (images/images) - Drag and Drop worked.
Set TinyMCE to just a sub-directory under the main images directory - Drag and Drop worked.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25037.}

Quy - comment - 30 May 2019

I have tested this item ✅ successfully on e2becdf

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25037.}

Quy - comment - 30 May 2019

I have tested this item ✅ successfully on e2becdf

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25037.}

Quy - test_item - 30 May 2019 - Tested successfully

Quy - change - 30 May 2019

Status

Pending

⇒

Ready to Commit

Quy - comment - 30 May 2019

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25037.}

dgrammatiko - comment - 30 May 2019

The test instructions don’t reflect what that part of the code was supposed to cover. You need to test this after setting a different directory for the images in com_media...

franz-wohlkoenig - comment - 31 May 2019

@dgrammatiko should RTC be removed?

HLeithner - comment - 31 May 2019

@dgrammatiko thx for the info but the parameter in the plugin doesn't add the base path to the return value, so it's not needed anyway or do I missing something in the history?

Updated test instructions.

HLeithner - change - 31 May 2019

The description was changed

HLeithner - edited - 31 May 2019

dgrammatiko - comment - 31 May 2019

As far as I understand the issue is that if you populate the field in tinymce for the final storage path people expect it to be relative to images but in reality it always wasn’t. Actually a better description for that field would do here (eg if you want a folder something relative to images then type images/something). By the way removing this logic in staging is a B/C break for those not using the root/images path for the media manager (I’m one of those few ppl)

HLeithner - comment - 31 May 2019

You can't enter a path in the plugin I think you created a new fieldtype "imagespath" and you have to select it from the dropdown.

brianteeman - comment - 31 May 2019

@dgrammatiko is referring to this option in the media manager

HLeithner - comment - 31 May 2019

thats the path used in the plugin and is added automatically on upload, not if you set the path in the plugin. ymmv

dgrammatiko - comment - 31 May 2019

@HLeithner quite honestly I thought that I had introduced that piece of code but looking at the initial commit of the drag and drop it seems that isn't the case, eg:

joomla-cms/plugins/editors/tinymce/tinymce.php

Lines 625 to 665 in 3bb31c8

    
           		if ($dragdrop && $user->authorise('core.create', 'com_media')) 
        
           		{ 
        
           			$allowImgPaste = "true"; 
        
           			$isSubDir      = ''; 
        
           			$session       = JFactory::getSession(); 
        
           			$uploadUrl     = JUri::base() . 'index.php?option=com_media&task=file.upload&tmpl=component&' 
        
           				. $session->getName() . '=' . $session->getId() 
        
           				. '&' . JSession::getFormToken() . '=1' 
        
           				. '&asset=image&format=json'; 
        
           			if (JFactory::getApplication()->isSite()) 
        
           			{ 
        
           				$uploadUrl = htmlentities($uploadUrl, null, 'UTF-8', null); 
        
           			} 
        
           			// Is Joomla installed in subdirectory 
        
           			if (JUri::root(true) != '/') 
        
           			{ 
        
           				$isSubDir = JUri::root(true); 
        
           			} 
        
           			// Get specific path 
        
           			$tempPath = $this->params->get('path', ''); 
        
           			if (!empty($tempPath)) 
        
           			{ 
        
           				$tempPath = rtrim($tempPath, '/'); 
        
           				$tempPath = ltrim($tempPath, '/'); 
        
           			} 
        
           			$dragDropPlg = 'jdragdrop'; 
        
           			JText::script('PLG_TINY_ERR_UNSUPPORTEDBROWSER'); 
        
           			JFactory::getDocument()->addScriptDeclaration( 
        
           				" 
        
           		var setCustomDir    = '" . $isSubDir . "'; 
        
           		var mediaUploadPath = '" . $tempPath . "'; 
        
           		var uploadUri       = '" . $uploadUrl . "'; 
        
           				" 
        
           			); 
        
           		}

the code doesn't have all these preg/replaces there... (#7435 )
Then looking at the github blame #15057 comes up as the bug source.
Anyways by reviewing the code I think this should work fine, all the extra code there is kinda bloat but please check the case when a user has a diferent media path than the standard images folder

HLeithner - comment - 31 May 2019

@dgrammatiko ok thx, I added the imagepath property to the test instructions and tested it by my self without any problems for the drag and drop upload.

Quy - comment - 2 Jun 2019

Tested successfully with a different image root folder.

4c8e102 3 Jun 2019

Merge branch 'staging' into tinymce-dnd-path

rdeutz - comment - 3 Jun 2019

All JSessionTest are failing because of "Warning: A non-numeric value encountered in C:\projects\joomla-cms\libraries\vendor\joomla\string\src\phputf8\utf8.php on line 38"

I can't tell what is wrong and I am sorry but I don't have the time now to dig into this deeper. Just reporting, this fails only on 7.2

HLeithner - change - 5 Jun 2019

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2019-06-05 15:38:15
Closed_By		⇒	HLeithner

HLeithner - close - 5 Jun 2019

HLeithner - merge - 5 Jun 2019

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#25037] - Tinymce doesn't need to remove the images basepath

Summary of Changes

Testing Instructions

Expected result

Actual result

Add a Comment

	if ($dragdrop && $user->authorise('core.create', 'com_media'))
	{
	$allowImgPaste = "true";
	$isSubDir = '';
	$session = JFactory::getSession();
	$uploadUrl = JUri::base() . 'index.php?option=com_media&task=file.upload&tmpl=component&'
	. $session->getName() . '=' . $session->getId()
	. '&' . JSession::getFormToken() . '=1'
	. '&asset=image&format=json';

	if (JFactory::getApplication()->isSite())
	{
	$uploadUrl = htmlentities($uploadUrl, null, 'UTF-8', null);
	}

	// Is Joomla installed in subdirectory
	if (JUri::root(true) != '/')
	{
	$isSubDir = JUri::root(true);
	}

	// Get specific path
	$tempPath = $this->params->get('path', '');

	if (!empty($tempPath))
	{
	$tempPath = rtrim($tempPath, '/');
	$tempPath = ltrim($tempPath, '/');
	}

	$dragDropPlg = 'jdragdrop';

	JText::script('PLG_TINY_ERR_UNSUPPORTEDBROWSER');
	JFactory::getDocument()->addScriptDeclaration(
	"
	var setCustomDir = '" . $isSubDir . "';
	var mediaUploadPath = '" . $tempPath . "';
	var uploadUri = '" . $uploadUrl . "';
	"
	);
	}