[#25034] - [4.0] Cleanup the View files com_admin
- Fixed in Code Base
- 24 Jun 2019
- Medium
- Build: 4.0-dev
- # 25034
- Diff
- roland-d:feature/com-admin-view-model
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is a first step in cleaning up the view files and adhering to coding standards as well as making the views more usable by the IDE by removing the magic getter.
Testing Instructions
- Go to System -> System Information
- Check that the page still works
- Click on the
Download as text - Check that the file is generated
- Click on the
Download as JSON - Check that the file is generated
- Click on Help in the left menu
- Click on Joomla! Help
- Check that the page still shows
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25034.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25034.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25034.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25034.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25034.
Pleasebe aware that these changes are PHP7.2.
But otherwise love it. Thanks for this work.
Not yet... Right now the minimum version is still declared 7.0. I completely agree with all the changes and also with going to 7.2, but it would have to be announced first (and changed in code) that we are switching to 7.2. See my PRs related to that, too.
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
Holding on this until the official announcement comes in production minutes for this if it's requiring 7.2 (and we can update composer files etc)
| Category | Administration com_admin | ⇒ | Administration com_admin com_associations |
| Status | Ready to Commit | ⇒ | Pending |
| Category | Administration com_admin com_associations | ⇒ | Administration com_admin |
| Labels |
Removed:
?
|
||
@Quy It is also a change to standardize on our CamelCase codestyle but in a completely different place. So it is a valid PR in it's own right. Yes, it is a very old PR, I don't know if the owner wants to update or if it is still needed, that depends on the conflicts.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-24 11:14:16 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on e06d193
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25034.