[#25032] - [4.0] modal toolbar layout
- Fixed in Code Base
- 29 May 2019
- Medium
- Build: 4.0-dev
- # 25032
- Diff
- brianteeman:modal
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
As far as I can tell this layout is only used administrator/index.php?option=com_banners&view=tracks for the export button.
If you look at the screenshots you will see that the export button is indented more than the new button.
This is because there is some css for the first button.
.subhead .btn-toolbar>:first-child { margin-left: 0; }
This should be applied to the export button as well but its not hence the indentation.
This is caused by the layout rendering the div for the modal before the button. This means that the button is no longer the first-child
This simple PR changes the order of the div and the button to resolve this.
After PR
NOTE any issues with the rendering of the modal are beyond the scope of this PR
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
I have tested this item
The "Export" button on "Banners: Tracks" is now aligned the same as on the other views.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25032.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-29 11:07:53 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thanks - took me far too long to work out the issue
I have tested this item✅ successfully on 72b8f91
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25032.