J4 Issue ?
avatar hgh-esn
hgh-esn
27 May 2019

### Steps to reproduce the issue
There must be a plugin installed, witch has the necessary changelog-/server and -data activ. See
Go into System>Update>Extensions. In the upcoming extension-update-listview the changelog-item fails

### Expected result

There should be a link to a modal-windows at the changelog-item

### Actual result

I get no "changelog-version-item-link". Instead of this, I see N/A or in German: Unbekannt
2019-05-27_13h49_31

### System information (as much as possible)

J4-alpha-dev-10 (NightlyBuild: 190525)

### Additional comments

avatar hgh-esn hgh-esn - open - 27 May 2019
avatar joomla-cms-bot joomla-cms-bot - change - 27 May 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 27 May 2019
avatar ReLater
ReLater - comment - 27 May 2019

See Issue #23063

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 May 2019

@ReLater so its a known issue?

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 May 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 27 May 2019
avatar hgh-esn hgh-esn - change - 27 May 2019
The description was changed
avatar hgh-esn hgh-esn - edited - 27 May 2019
avatar ReLater
ReLater - comment - 27 May 2019

so its a known issue?

No. I was wrong. 2 different issues.

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 May 2019
Status New Discussion
avatar hgh-esn
hgh-esn - comment - 30 May 2019

@ReLater
And when you or someone else will make a change to bring back the origin functionality?

avatar ReLater
ReLater - comment - 30 May 2019

I can confirm this issue. I've build a custom plugin and followed the documentation https://docs.joomla.org/Adding_changelog_to_your_manifest_file

The updateserver infos are: https://raw.githubusercontent.com/ReLater/plg_system_changelogtest/master/updateserver-infos.xml

The cahngelog infos are https://raw.githubusercontent.com/ReLater/plg_system_changelogtest/master/changelog-infos.xml

After installing of version 0.0.1 of my test plugin.

Everything's OK in view "Extensions Manage"

30-05-_2019_12-18-53

but not in view "Extensions: Update":

30-05-_2019_12-18-03

After tests with my own plugin I tested with:
https://github.com/roland-d/component_joomla/releases/tag/v0.0.2

There the changelog in view "Extensions: Update" is empty:
30-05-_2019_12-44-02

@roland-d (creator of pr #24026

And when you or someone else will make a change to bring back the origin functionality?

Sorry, I have no idea how.

avatar ReLater
ReLater - comment - 30 May 2019

Addition:
After installation of my plugin field changelogurl in database table #__updates is empty (NULL).

30-05-_2019_12-57-03

When I add it manually I see the Changelog button but the update changelog for version 0.0.2 is empty, too.

30-05-_2019_13-02-13

avatar ReLater
ReLater - comment - 30 May 2019

Addition 2:

I sse now 2 Changelog buttons. But both open the same empty changelog of my plugin version 0.0.2

30-05-_2019_13-06-41

And when I make a database fix for Joomla CMS my manually added changelogurl is removed from database table #__updates. Somehow weird. At least too weird for me ;-)

avatar roland-d
roland-d - comment - 30 May 2019

I will take a look

avatar roland-d
roland-d - comment - 30 May 2019

This is also related to PR #24890 which I need to fix again due to the conflict.

@ReLater There is an issue with your manifest file. This manifest file: https://raw.githubusercontent.com/ReLater/plg_system_changelogtest/master/updateserver-infos.xml has no changelogurl tag in it. That is why it is missing from the updates table.

See my test manifest file here: https://rolandd.com/24026/lists.xml

@hgh-esn I think you have the same issue.

As far as I can tell, nothing is broken, just the manifest file is missing the changelogurl node.

avatar roland-d
roland-d - comment - 30 May 2019

Now that #24890 is merged, you may want to update your test installation as well. This contains some important fixes.

avatar ReLater
ReLater - comment - 30 May 2019

There is an issue with your manifest file. This manifest file: updateserver-infos.xml has no changelogurl tag in it. That is why it is missing from the updates table.

I tried it without and with tag but then had the empty popup and was unsure... I've added an example code to the documentation to clarify which manifest file we talk about:
https://docs.joomla.org/Adding_changelog_to_your_manifest_file

avatar roland-d
roland-d - comment - 30 May 2019

The empty popup is because of issue #24890 It should work after you have those changes. In case you use the nightly build, you will have to wait till tomorrow, otherwise you need to run npm run build:js from the root folder.

avatar ReLater
ReLater - comment - 30 May 2019

Thanks! Will wait for the next nightly.

avatar hgh-esn
hgh-esn - comment - 30 May 2019

@roland-d

Thanks for your quick work - I'll wait also until the next nightly tomorrow.

..... I think you have the same issue.
I have this issue , but I have the changelogurl tag in my manifest-file.

avatar ReLater
ReLater - comment - 31 May 2019

Tested successfully. All issues are solved.
Thank you!

avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2019
Labels
avatar joomla-cms-bot joomla-cms-bot - close - 31 May 2019
avatar alikon alikon - change - 31 May 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-05-31 13:23:22
Closed_By alikon
Labels
avatar joomla-cms-bot
joomla-cms-bot - comment - 31 May 2019

Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/25017

avatar hgh-esn
hgh-esn - comment - 31 May 2019

@roland-d
sorry, I could get it to run, but I haven't any content in the popping up modal.
I miss the oncklick="(...)" in the /administrator/components/com_installer/tmpl/update/default.php
Is that right?

@ReLater
Do you have content in the modal?

avatar roland-d
roland-d - comment - 1 Jun 2019

@hgh-esn Make sure you have the last nightly build. This contains all the needed changes to make it work.

avatar ReLater
ReLater - comment - 1 Jun 2019

Do you have content in the modal?

Yes. All worked as expected after update to before-last nightly.
Maybe you want to test and check my plugin https://github.com/ReLater/plg_system_changelogtest . All relevant files can be seen in the master branch.
Install release 0.0.1!

Only the close buttons of the popups don't work corecctly but as far as I see that's a CSS issue.
01-06-_2019_13-30-40

avatar hgh-esn
hgh-esn - comment - 4 Jun 2019

@ReLater @roland-d

I got it to run now. But it was something strange.
For my tests of the earlier version, I renamed the file: .../changelog.xml -> .../changelogs.xml

  • I found this name better, because of having more than one <update>-tags in there. So (with 's') it was in the database after the plugin-installation..

To test the latest version I haven't deinstalled my example plugin. But the xml-filename now was changed back - by default - to .../changelog.xml without 's'. So it doesn't match to the db-entry and I only saw the modal with it's header line and a "blank" content area..

There was no message for the mismatching filenames.

@roland-d
It will be great, if you will give out an alert in the modal or as joomla-message, if there is a conflict between the filenames in the <updateurl-tag> of the xml-file and that, what is stored in the database.

@ReLater
The close button of the modal is ok in my tests as you can see here..
2019-06-04_03h03_07

@roland-d
Just another effect.
When you stay at an update-screen and the session becomes a timeout, you will see this message in the modal, when clicking to the version-link or update-button on the stayed screen - without reacting Joomla by a new login.:
2019-06-04_03h20_04

That is a bit cryptical to users. Is there a way to bring out a more user readable message?

And last:
Where is that js-stored in the joomla file-structure?

.

avatar roland-d
roland-d - comment - 4 Jun 2019

@hgh-esn I find it hard to follow what you are doing.

It will be great, if you will give out an alert in the modal or as joomla-message, if there is a conflict between the filenames in the of the xml-file and that, what is stored in the database.

If you manually change the file on your server, you cannot expect Joomla to know what file you have there. If you want an updated changelog file to be read, you will need to re-install the extension.

That is a bit cryptical to users. Is there a way to bring out a more user readable message?

Please create a new issue for it so we can look into it. This issue is closed.

Where is that js-stored in the joomla file-structure?

build/media_source/com_installer/js/changelog.es6.js

avatar 810
810 - comment - 12 May 2020

Hi, can this issue open again, because on install the changelogurl is again empty with <changelogurl> on xml.

avatar ReLater
ReLater - comment - 12 May 2020

Hi, can this issue open again, because on install the changelogurl is again empty with on xml.

Is this related anyhow? #29037

avatar 810
810 - comment - 12 May 2020

No, on clean new install the plugin changelogurl isn't saved on the database on _extensions. other types (package/component/media/library) are working.

avatar zero-24
zero-24 - comment - 12 May 2020

Hi, can this issue open again, because on install the changelogurl is again empty with on xml.

Well what about opening a new issue and add a link there? As this issue was closed 31 May 2019 nearly one year ago?

Add a Comment

Login with GitHub to post a comment