[#25006] - [4.0] Changing phpcs to run from composer and a generic image in drone
- Fixed in Code Base
- 1 Jun 2019
- Medium
- Build: 4.0-dev
- # 25006
- Diff
- Hackwar:j4phpcs2
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
What the title says.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
It looks like it's still the same order but uses not a custom image or Hannes?
@HLeithner if you look at the failed build you will see it runs after the prepare step, so a failed build will need 6 minutes more than before. I made a docker image based on 7.2-cli and installed phpcs v2 within it
@rdeutz the issue is we want to run phpcs from the standards located here https://github.com/joomla/coding-standards which means we need to have run composer install first (although not the npm install). So unless we separate them (which would be fine - i think npm is the majority of the 6 minutes). we have to run after prepare
| Labels |
Added:
?
?
|
||
That's absolutely fine. The cached version of composer should be just fine for this!
I've updated the order of steps and that should make it rather fast enough. Unfortunately we seem to have a discrepancy between the sniffs in our phpcs image and our repo or something like that. Anyway, it fails at that one file.
| Category | Unit Tests | ⇒ | Unit Tests Repository |
I excluded the node_modules folder and now this passes. (I also ordered the excluded folders alphanumerically.)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-01 15:27:19 |
| Closed_By | ⇒ | wilsonge |
Thanks!
The idea to let phpcs run as early as possible is the this is cheap and fast. It gives the developer a soon notice that the coding style is not correct. This is not a good idea, it will bind our resources for a longer timeframe, because as we know most of the PR needs corrections for code styles.