? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
23 May 2019

Summary of Changes

showon was broken in com_menus. this fixes it by adding an id to the hidden field for menu type which was failing

Testing Instructions

Before patch see console error when editing a menu item. after patch it's gone and showon attributes work correctly (publish up/down based on home page and template style based on menu item)

Documentation Changes Required

none

avatar wilsonge wilsonge - open - 23 May 2019
avatar wilsonge wilsonge - change - 23 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2019
Category Administration com_menus
avatar wilsonge wilsonge - change - 23 May 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 23 May 2019
Title
Fix showon error in com_menus
[4.0] Fix showon error in com_menus
avatar wilsonge wilsonge - edited - 23 May 2019
avatar SharkyKZ
SharkyKZ - comment - 24 May 2019

I have tested this item successfully on c1c02ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24996.

avatar SharkyKZ SharkyKZ - test_item - 24 May 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 24 May 2019

I have tested this item successfully on c1c02ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24996.

avatar infograf768 infograf768 - test_item - 24 May 2019 - Tested successfully
avatar infograf768 infograf768 - change - 24 May 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 24 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24996.

avatar infograf768
infograf768 - comment - 24 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24996.

avatar infograf768 infograf768 - change - 24 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-24 06:44:43
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 24 May 2019
avatar infograf768 infograf768 - merge - 24 May 2019
avatar infograf768
infograf768 - comment - 24 May 2019

tks

Add a Comment

Login with GitHub to post a comment