? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 May 2019

In Bootstrap 4 they "dropped the .btn-xs class entirely as .btn-sm is proportionally much smaller than v3’s."

A previous PR added the css back for the frontend template.

This PR removes that additional class and instead replaces the uses of btn-xs with btn-sm

Also removes the markup pull-xs-right which doesn't exist in the css. No point giving it the float-right as it looks really silly

Fixes #21244

avatar brianteeman brianteeman - open - 22 May 2019
avatar brianteeman brianteeman - change - 22 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2019
Category Administration com_content com_installer Front End com_contact com_newsfeeds Libraries Templates (site)
avatar brianteeman brianteeman - change - 22 May 2019
Labels Added: ?
avatar Quy
Quy - comment - 22 May 2019

I have tested this item successfully on 9581a54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24979.

avatar Quy
Quy - comment - 22 May 2019

I have tested this item successfully on 9581a54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24979.

avatar Quy Quy - test_item - 22 May 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 May 2019

Updating branch to trigger drone

avatar wilsonge wilsonge - change - 24 May 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-24 20:58:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 May 2019
avatar wilsonge wilsonge - merge - 24 May 2019
avatar wilsonge
wilsonge - comment - 24 May 2019

Thanks!

avatar brianteeman
brianteeman - comment - 24 May 2019

Thanks

Add a Comment

Login with GitHub to post a comment