? ? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
22 May 2019

Pull Request for Issue #14899 .

Summary of Changes

This replaces conflicting filter attribute in Joomla\CMS\Form\Field\FilelistField and Joomla\CMS\Form\Field\FolderlistField with new fileFilter and folderFilter attributes, respectively.

Testing Instructions

Code review is fine, I guess. Or add filelist/folderlist field to a form, set fileFilter/folderFilter attribute and check that files/folders are filtered correctly. E.g.:

<field
	name="image"
	type="filelist"
	fileFilter="\.png$"
	directory="images/banners"
/>

Documentation Changes Required

Yes. B/C break: existing forms using affected fields need to be updated with new attributes. Fields extending these fields need to be updated.

avatar SharkyKZ SharkyKZ - open - 22 May 2019
avatar SharkyKZ SharkyKZ - change - 22 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2019
Category Administration com_languages Libraries Front End Plugins
avatar SharkyKZ SharkyKZ - change - 22 May 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 22 May 2019
avatar Quy
Quy - comment - 26 May 2019

I have tested this item successfully on e0ce991


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24977.

avatar Quy Quy - test_item - 26 May 2019 - Tested successfully
avatar alikon
alikon - comment - 27 May 2019

I have tested this item successfully on e0ce991


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24977.

avatar alikon
alikon - comment - 27 May 2019

I have tested this item successfully on e0ce991


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24977.

avatar alikon alikon - test_item - 27 May 2019 - Tested successfully
avatar alikon alikon - change - 27 May 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 27 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24977.

avatar wilsonge wilsonge - change - 27 May 2019
Labels Added: ? ?
avatar wilsonge wilsonge - change - 27 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-27 22:29:49
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 27 May 2019
avatar wilsonge wilsonge - merge - 27 May 2019
avatar wilsonge
wilsonge - comment - 27 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment