Feeling Lucky
?
?
[#24971] - Changed the default value to type double
- Fixed in Code Base
- 1 Jun 2019
- Medium
- Build: staging
- # 24971
- Diff
- Quy:patch-1
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Redo of PR #15743
The PHPdoc declares the variable as "double"
@param double $startTime
but the method initialises its default value with an "integer" instead
$startTime = 0
Summary of Changes
Changed the default value to type double
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
alikon
- comment
- 21 May 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24971.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 21 May 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24971.
| Labels |
Added:
?
|
||
richard67
- comment
- 1 Jun 2019
@HLeithner I think this should me merged.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-01 13:44:28 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 1 Jun 2019
Thx
I have tested this item✅ successfully on aa5cc84
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24971.