User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Title |
|
Title |
|
Category | ⇒ | Modules Administration |
Labels |
Added:
?
|
Sorry but this looks to be a band aid solution and doesn't address the real issue as we are going to see the same problem throughout joomla and extensions wherever we use the publish_up date. Surely the fix is to return to the j3 method of setting the article publish_up date as equally to the created date by default instead of setting it to null.
What do you suggest to show in the modules if the publish_up date is null?
I just took a closer look and actually its complicated
The behaviour now in Joomla 4 is that if you create a new article with a status of unpublished then it is created with a null for publish_up
If you go in to the article and change the status to publish and then save and you get a publish_up of now
BUT If you change the status from the list view then you do not get a publish_up date at all
So I think there are two seperate bugs here.
When Issue 1 is fixed then the only time you will not have a publish_up date is when it is not published. So in that scenario we should be displaying "Unpublished" - displaying two different dates (published/created) is not correct
OR it can always display created date
I would assume by the name of that module, Popular Articles, that it does not show unpublished articles at all, because how shall an article become popular if it has never been published, or how shall it become more popular if it ever had been published and then was unpublished. But that's maybe only my opinion.
You assume incorrectly. It might have been published in the past for example
Yes, and then be unpublished again. Question is if it then still makes sense to show it in the list of popular articles. I think that's a matter of taste.
Anyway, bug no. 1 with the status change in the list view to published does not set the publish date, this has to be fixed.
For 2. I think showing text "Unpublished" would be good for my taste, if that is possible.
Maybe showing the create date is the simplest and clearest solution. All other possible combinations need explanation. If the haeder says "Date created" instead of "Date" it is clear enough, no matter which history the article has gone through.
Additionally, the items could get the icon for published/unpublished also on the
modules.
Please fix conflicts and see related PRs regarding null value for dates.
If an article is newly created with unpublished state, the publish_up time is null in PHP and NULL in SQL after recent merged PRs. Before it was set to (pseudo-)nulldates in that case. In this case the publish_up time should NOT be set to the created time. As soon as the article is published, publish_up should be set by the software, otherwise it is a bug and has to be fixed. An article newly created with published state should also have publish_up set. Unpublished articles should not be shown by these modules, as far as I understand. So I would recommend to test if the issue which shall be solved by this PR still is an issue on current 4.0-dev branch. If it still is, I will check and advise how to fix, otherwise if it is not an isue anymore, this issue can be closed.
Thank you for your time and information. The original issue (new itemwit date -0001 .. ) is solved in 4.0,
So I'll close this ussue.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-17 18:10:48 |
Closed_By | ⇒ | chmst | |
Labels |
Added:
Conflicting Files
|
Sometimes we are lucky with J4
The same is true for Recently Added Articles