Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24965] - [4.0] [com_contact] convert to prepared statement

? Failure

User tests: Successful: Unsuccessful:

avatar alikon
alikon
20 May 2019

Summary of Changes

use prepared statement for SQL

Testing Instructions

test com_contact

Expected result

should work as before

Actual result

don't use prepared statements

avatar alikon alikon - open - 20 May 2019
avatar alikon alikon - change - 20 May 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2019
Category ⇒ Administration com_contact Front End
avatar alikon alikon - change - 20 May 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 May 2019
Title
…
[4.0][com_contact] convert to prepared statement
[4.0] [com_contact] convert to prepared statement
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 May 2019
Title
…
[4.0][com_contact] convert to prepared statement
[4.0] [com_contact] convert to prepared statement
avatar franz-wohlkoenig franz-wohlkoenig - edited - 21 May 2019
5d4139d 21 May 2019 avatar alikon cs
f97061e 21 May 2019 avatar alikon cs
1829cb0 21 May 2019 avatar alikon cs
avatar SharkyKZ
SharkyKZ - comment - 27 May 2019

What's the consensus on throwing exceptions vs using setError() and returning false in models? I see a mix of both in same model, e.g.

joomla-cms/components/com_contact/Model/ContactModel.php

Lines 194 to 197 in 48e6af8

if ($data === null)
{
throw new \Exception(Text::_('COM_CONTACT_ERROR_CONTACT_NOT_FOUND'), 404);
}
and

joomla-cms/components/com_contact/Model/ContactModel.php

Lines 251 to 253 in 48e6af8

$this->setError($e);
$this->_item[$pk] = false;
}

avatar SharkyKZ
SharkyKZ - comment - 27 May 2019

Nevermind, exception is thrown inside try/catch.

16e306e 1 Jun 2019 avatar alikon grr
avatar wilsonge wilsonge - change - 3 Jun 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-06-03 16:34:39
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 3 Jun 2019
avatar wilsonge wilsonge - merge - 3 Jun 2019
avatar wilsonge
wilsonge - comment - 3 Jun 2019

Thanks!

Add a Comment

Login with GitHub to post a comment