[#24941] - [4.0.] Remove obsolete and outdated trigger
- Fixed in Code Base
- 19 May 2019
- Medium
- Build: 4.0-dev
- # 24941
- Diff
- roland-d:feature/remove-obsolete-trigger
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This removes the outdated and obsolete trigger. The correct trigger happens the line above.
Testing Instructions
- Go to Systems
- Go to Plugins
- Open plugin
Action Log - Joomla - Click on
Save - Notice you get the following error:
Expected result
Plugin is saved
Actual result
Class 'JEventDispatcher' not found error
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24941.
| Labels |
Added:
?
|
||
@alikon There is definitely a confusion with 2 triggers with basically the same name. What is the difference between them? One is J4 and the other is for J3?
@richard67 I have added the trigger as suggested
Would be confusing me if the was no confusion in J4 ;-) (joke)
I have tested this item
Note: The testing instructions only tell 1 example when that error happens. It happens also with other actions like e.g. enable/disable any plugin with the button in the plugins list view. This PR fixes all of them.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24941.
onAfterCheckin is worked by the actionlog joomla plugin https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/actionlog/joomla/joomla.php#L924
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24941.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24941.
| Labels |
Added:
?
|
||
FYI, there are other places where the error happens: for example when playing with custom admin menus. PR also solves issue there.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-19 06:30:03 |
| Closed_By | ⇒ | infograf768 |
Thanks.
Thank you
I have tested this item✅ successfully on f2d08b1
Note: The testing instructions only tell 1 example when that error happens. It happens also with other actions like e.g. enable/disable plugin with button in list view. This PR fixes all of them.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24941.