? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
17 May 2019

Pull Request for Issue #24938 .

Summary of Changes

Fixes 0 value usage in range field.

Testing Instructions

Add range field with default value 0 to any form:

<field 
	name="testrange" 
	type="range" 
	label="Test Range" 
	description="Test range desc" 
	min="-10" 
	max="10"
	step="0.1" 
	class="" 
	default="0"
/>

View the form. Look at the field.

Expected result

Slider is at 0 value (centered).

Actual result

Slider is at -10 value (left).

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 17 May 2019
avatar SharkyKZ SharkyKZ - change - 17 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2019
Category Layout
avatar Quy
Quy - comment - 17 May 2019

I have tested this item successfully on fcc96ac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24939.

avatar Quy
Quy - comment - 17 May 2019

I have tested this item successfully on fcc96ac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24939.

avatar Quy Quy - test_item - 17 May 2019 - Tested successfully
avatar SharkyKZ SharkyKZ - change - 17 May 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 17 May 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 May 2019
avatar thednp
thednp - comment - 17 May 2019

@franz-wohlkoenig I tested the change directly into the code, it fixes the issue.

avatar alikon
alikon - comment - 17 May 2019

I have tested this item successfully on fcc96ac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24939.

avatar alikon
alikon - comment - 17 May 2019

I have tested this item successfully on fcc96ac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24939.

avatar alikon alikon - test_item - 17 May 2019 - Tested successfully
avatar Quy Quy - change - 17 May 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 17 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24939.

avatar HLeithner HLeithner - change - 18 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-18 12:26:46
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 18 May 2019
avatar HLeithner HLeithner - merge - 18 May 2019
avatar HLeithner
HLeithner - comment - 18 May 2019

thx

Add a Comment

Login with GitHub to post a comment